Gentoo Archives: gentoo-dev

From: Samuli Suominen <ssuominen@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass
Date: Mon, 05 Jul 2010 21:48:42
Message-Id: 4C325386.8060902@gentoo.org
In Reply to: Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass by Arfrever Frehtes Taifersar Arahesis
On 07/06/2010 12:38 AM, Arfrever Frehtes Taifersar Arahesis wrote:
> 2010-07-05 23:28:01 Samuli Suominen napisał(a): >> On 07/05/2010 11:23 PM, Arfrever Frehtes Taifersar Arahesis wrote: >>> 2010-07-05 21:18:57 Mark Loeser napisał(a): >>>> Arfrever Frehtes Taifersar Arahesis <Arfrever@g.o> said: >>>>> 2010-07-05 20:00:11 Mark Loeser napisał(a): >>>>>> Everyone else has already made valid points. I'm just picking this one >>>>>> to reply to now. Please remove the colors you have added. If you need >>>>>> a new function, say "eqawarn", we should have that added in the next >>>>>> EAPI with a description of when and where to use it. >>>>> >>>>> In case of the colored message added in this patch, if einfo/elog/ewarn/eqawarn/eerror was used, >>>>> then its output wouldn't be logged by Portage. >>>> >>>> I don't understand what you are trying to say. >>> >>> Portage doesn't log output of einfo/elog/ewarn/eqawarn/eerror called in global scope. >> >> Can you point to the location of python.eclass / distutils.eclass where >> you need to send output from global scope, please? > > It's at the beginning of this patch. NEED_PYTHON is parsed in global scope. >
OK, so let me get this right... are trying to justify using all of the echo+custom colorization in the eclass by this one occurance, in basis of it doesn't get logged otherwise? Seems a bit far fetch. Also I'm not convinced if it's beneficial to log this.

Replies

Subject Author
Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass Arfrever Frehtes Taifersar Arahesis <Arfrever@g.o>