Gentoo Archives: gentoo-dev

From: Donnie Berkholz <dberkholz@g.o>
To: gentoo-dev@l.g.o, nerdboy@g.o
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/hylafax: ChangeLog hylafax-4.4.4.ebuild
Date: Sun, 13 Jul 2008 23:17:42
Message-Id: 20080713231738.GM1891@comet
1 On 23:05 Sun 13 Jul , Steve Arnold (nerdboy) wrote:
2 > 1.1 net-misc/hylafax/hylafax-4.4.4.ebuild
3 >
4 > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-misc/hylafax/hylafax-4.4.4.ebuild?rev=1.1&view=markup
5 > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-misc/hylafax/hylafax-4.4.4.ebuild?rev=1.1&content-type=text/plain
6
7 > src_compile() {
8 > # gcc standard C++ header changes
9 > if [ $(gcc-major-version) -eq 4 ] && [ $(gcc-minor-version) -ge 3 ] ; then
10 > sed -i -e 's:"new.h":<new>:g' configure util/Types.h || die "sed failed"
11 > sed -i -e 's:"iostream.h":<iostream>\n using namespace std;:g' \
12 > configure || die "sed failed"
13 > fi
14
15 Has a patch been sent upstream for this?
16
17 > if use html; then
18 > my_conf="${my_conf} --with-HTML=yes"
19 > else
20 > my_conf="${my_conf} --with-HTML=no"
21 > fi
22
23 Does this work?
24
25 my_conf="${my_conf} $(use_with html HTML)"
26
27 > #--enable-pam isn't valid
28 > use pam || my_conf="${my_conf} $(use_enable pam)"
29
30 Might avoid some confusion with just --disable-pam since --enable
31 doesn't work.
32
33 > # eval required for quoting in ${my_conf} to work properly, better way?
34 > eval ./configure --nointeractive ${my_conf} || die "./configure failed"
35
36 That's kinda gross. What exactly is the problem?
37
38 > emake -j1 || die "emake failed"
39
40 Have you filed an upstream bug about parallel build being broken?
41
42 > generate_files # in this case, it only generates the env.d entry
43 >
44 > einfo "Adding env.d entry for Hylafax"
45 > doenvd 99${P}
46
47 doenvd doesn't die on failure.
48
49 > einfo "Adding init.d entry for Hylafax"
50 > newinitd "${FILESDIR}"/${PN}-4.2 ${PN}
51
52 Neither does newinitd.
53
54 --
55 Thanks,
56 Donnie
57
58 Donnie Berkholz
59 Developer, Gentoo Linux
60 Blog: http://dberkholz.wordpress.com