Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: hasufell@g.o
Subject: Re: [gentoo-dev] [PATCH vcs-snapshot] Use ${WORKDIR}/${P} rather than ${S} to support ${S} overrides.
Date: Mon, 04 Jun 2012 15:50:37
Message-Id: 20120604175047.1d1ed5a4@pomiocik.lan
In Reply to: Re: [gentoo-dev] [PATCH vcs-snapshot] Use ${WORKDIR}/${P} rather than ${S} to support ${S} overrides. by hasufell
On Mon, 04 Jun 2012 16:20:02 +0200
hasufell <hasufell@g.o> wrote:

> -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 06/04/2012 11:59 AM, Michał Górny wrote: > > One could set S to work on a subtree of the tarball rather than the > > whole tarball. Considering that, it's probably better to use > > ${WORKDIR}/${P} rather than ${S}. > > > > Fixes: https://bugs.gentoo.org/show_bug.cgi?id=419479 --- > > gx86/eclass/vcs-snapshot.eclass | 5 +++-- 1 file changed, 3 > > insertions(+), 2 deletions(-) > > > > diff --git a/gx86/eclass/vcs-snapshot.eclass > > b/gx86/eclass/vcs-snapshot.eclass index 6748360..23cd696 100644 --- > > a/gx86/eclass/vcs-snapshot.eclass +++ > > b/gx86/eclass/vcs-snapshot.eclass @@ -9,7 +9,8 @@ # @DESCRIPTION: # > > This eclass provides a convenience src_unpack() which does support > > # working with snapshots generated by various VCS-es. It unpacks > > those -# to ${S} rather than the original directory containing > > commit id. +# to ${WORKDIR}/${P} rather than the original directory > > containing +# commit id. # # Note that this eclass handles only > > unpacking. You need to specify # SRC_URI yourself, and call any > > autoreconfiguration as necessary. @@ -41,5 +42,5 @@ > > vcs-snapshot_src_unpack() { > > > > # github, bitbucket: username-projectname-hash # gitweb: > > projectname-tagname-hash - mv *-*-[0-9a-f]*[0-9a-f]/ "${S}" > > || die > > + mv *-*-[0-9a-f]*[0-9a-f]/ "${WORKDIR}"/${P} || die } > > Currently that eclass does not support multiple snapshot > sources/tarballs.
Use case? -- Best regards, Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies