From: | Alec Warner <antarus@g.o> | ||
---|---|---|---|
To: | gentoo-dev@l.g.o | ||
Cc: | je_fro@g.o | ||
Subject: | Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sci-biology/seaview: ChangeLog seaview-20060213.ebuild seaview-20041220.ebuild seaview-20070919.ebuild | ||
Date: | Mon, 22 Oct 2007 04:36:03 | ||
Message-Id: | b41005390710212120i78dfb141v11238691d60a7a26@mail.gmail.com | ||
In Reply to: | [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sci-biology/seaview: ChangeLog seaview-20060213.ebuild seaview-20041220.ebuild seaview-20070919.ebuild by Donnie Berkholz |
1 | On 10/21/07, Donnie Berkholz <dberkholz@g.o> wrote: |
2 | > On 04:34 Sun 21 Oct , Jeffrey Gardner (je_fro) wrote: |
3 | > > 1.3 sci-biology/seaview/seaview-20060213.ebuild |
4 | > > |
5 | > > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/sci-biology/seaview/seaview-20060213.ebuild?rev=1.3&view=markup |
6 | > > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/sci-biology/seaview/seaview-20060213.ebuild?rev=1.3&content-type=text/plain |
7 | > > diff : http://sources.gentoo.org/viewcvs.py/gentoo-x86/sci-biology/seaview/seaview-20060213.ebuild?r1=1.2&r2=1.3 |
8 | > |
9 | > > @@ -41,6 +41,6 @@ |
10 | > > |
11 | > > src_install() { |
12 | > > dobin seaview seaview_align.sh |
13 | > > - insinto /usr/share/${PN} |
14 | > > + insinto "/usr/share/${PN}" |
15 | > |
16 | > You only need to do this if $PN could have spaces in it (which should |
17 | > never be the case). Don't just blindly quote everything; by |
18 | > understanding why it's done, you can understand in which cases it should |
19 | > be done. |
20 | > |
21 | > I hope that repoman did not suggest this. |
22 | > |
23 | > Thanks, |
24 | > Donnie |
25 | |
26 | You told me on IRC 'people should quote all the time, as there is no |
27 | harm in overquoting' (aside from readability). Yet here you tell him |
28 | to 'not blindly quote everything'. So make up your mind ;) |
29 | |
30 | > -- |
31 | > gentoo-dev@g.o mailing list |
32 | > |
33 | > |
34 | -- |
35 | gentoo-dev@g.o mailing list |
Subject | Author |
---|---|
Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sci-biology/seaview: ChangeLog seaview-20060213.ebuild seaview-20041220.ebuild seaview-20070919.ebuild | Donnie Berkholz <dberkholz@g.o> |