Re: [gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update

[Michał Górny]

Dnia 2013-08-31, o godz. 15:00:43
Gilles Dartiguelongue <eva@g.o> napisał(a):

> Le samedi 31 août 2013 à 13:40 +0200, Michał Górny a écrit :
> > > +	cat "${tmp_file}" > "${EROOT}usr/$(get_libdir)/gdk-pixbuf-2.0/2.10.0/loaders.cache"
> >
> > Why not mv or cp? Also you need '|| die' here since 'cat' can fail
> > writing.
>
> I'd have to look back at the original bug report to get the exact reason
> but it seems mv/cp was not atomic enough.

Well, 'cat' is not atomic at all, so definitely not that :). 'mv' is
the only command that you can expect to at least try to be atomic.

It may had something to do with file metadata or symlinks.

> > And please ensure to remove it in pkg_postrm() when last version
> > of gdk-pixbuf is unmerged.
>
> I am not clear on this last sentence. Could you reformulate it please ?

In gdk-pixbuf, something like:

pkg_postrm() {
  # TODO: check if i used the correct variable :)
  [[ ${REPLACING_VERSIONS} ]] || rm -f "${EROOT}"usr/.../loaders.cache
}

-- 
Best regards,
Michał Górny