Gentoo Archives: gentoo-dev

From: Arfrever Frehtes Taifersar Arahesis <Arfrever@g.o>
To: Gentoo Development <gentoo-dev@l.g.o>
Subject: Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass
Date: Mon, 05 Jul 2010 22:07:04
Message-Id: 201007060007.02674.Arfrever@gentoo.org
In Reply to: Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass by Samuli Suominen
2010-07-05 23:49:58 Samuli Suominen napisał(a):
> On 07/06/2010 12:38 AM, Arfrever Frehtes Taifersar Arahesis wrote: > > 2010-07-05 23:28:01 Samuli Suominen napisał(a): > >> On 07/05/2010 11:23 PM, Arfrever Frehtes Taifersar Arahesis wrote: > >>> 2010-07-05 21:18:57 Mark Loeser napisał(a): > >>>> Arfrever Frehtes Taifersar Arahesis <Arfrever@g.o> said: > >>>>> 2010-07-05 20:00:11 Mark Loeser napisał(a): > >>>>>> Everyone else has already made valid points. I'm just picking this one > >>>>>> to reply to now. Please remove the colors you have added. If you need > >>>>>> a new function, say "eqawarn", we should have that added in the next > >>>>>> EAPI with a description of when and where to use it. > >>>>> > >>>>> In case of the colored message added in this patch, if einfo/elog/ewarn/eqawarn/eerror was used, > >>>>> then its output wouldn't be logged by Portage. > >>>> > >>>> I don't understand what you are trying to say. > >>> > >>> Portage doesn't log output of einfo/elog/ewarn/eqawarn/eerror called in global scope. > >> > >> Can you point to the location of python.eclass / distutils.eclass where > >> you need to send output from global scope, please? > > > > It's at the beginning of this patch. NEED_PYTHON is parsed in global scope. > > > > OK, so let me get this right... are trying to justify using all of the > echo+custom colorization in the eclass by this one occurance, in basis > of it doesn't get logged otherwise?
I was justifying using colors in this case (NEED_PYTHON). I'm completely against not using colors in status messages (e.g. "Building of dev-python/setuptools-0.6.13 with CPython 3.1..."), which are more useful, when they are easily noticeable by ebuild maintainers. I might agree to remove colors in other deprecation warnings, but this patch wasn't adding any other deprecation warnings. Not using colors in deprecation warnings doesn't have any benefits and only decreases noticeability of deprecation warnings. -- Arfrever Frehtes Taifersar Arahesis

Attachments

File name MIME type
signature.asc application/pgp-signature