Gentoo Archives: gentoo-dev

From: Jeroen Roovers <jer@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-misc/linux-logo: linux-logo-5.11.ebuild ChangeLog
Date: Fri, 24 Jun 2011 16:23:55
Message-Id: 20110624182217.1b4ca443@epia.jer-c2.orkz.net
In Reply to: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-misc/linux-logo: linux-logo-5.11.ebuild ChangeLog by Peter Volkov
On Fri, 24 Jun 2011 10:29:51 +0400
Peter Volkov <pva@g.o> wrote:

> > src_prepare() { > > echo "./logos/gentoo.logo" >> logo_config > > echo "./logos/gentoo2.logo" >> logo_config > > echo "./logos/banner-simplified.logo" >> logo_config > > echo "./logos/banner.logo" >> logo_config > > echo "./logos/classic-no_periods.logo" >> logo_config > > echo "./logos/classic-no_periods_or_chars.logo" >> > > logo_config echo "./logos/classic.logo" >> logo_config > > cat >> logo_config <<-EOF will look much better here.
src_prepare() { cat >> logo_config <<EOF line0 line1 line2 line3 EOF } Since I like indenting, I don't think so. Using FILESDIR is probably better, as mgorny suggested.
> > > cp "${FILESDIR}"/gentoo{,2}.logo "${S}"/logos/ > > || die
Good catch.
> > echo "NAME gentoo" >> "${S}"/logos/gentoo.logo > > } > > > > src_compile() { > > ARCH="" ./configure --prefix="${D}"/usr || die > > Why not src_configure()? > Also use econf or add # some comment here, please.
Legacy.
> > cp "${FILESDIR}"/${PN}.conf "${WORKDIR}" > > sed -i -e 's/-L 4 -f -u/-f -u/' "${WORKDIR}"/${PN}.conf > > || die
Yes. jer

Replies