| 1 |
On Fri, 24 Jun 2011 10:29:51 +0400 |
| 2 |
Peter Volkov <pva@g.o> wrote: |
| 3 |
|
| 4 |
> > src_prepare() { |
| 5 |
> > echo "./logos/gentoo.logo" >> logo_config |
| 6 |
> > echo "./logos/gentoo2.logo" >> logo_config |
| 7 |
> > echo "./logos/banner-simplified.logo" >> logo_config |
| 8 |
> > echo "./logos/banner.logo" >> logo_config |
| 9 |
> > echo "./logos/classic-no_periods.logo" >> logo_config |
| 10 |
> > echo "./logos/classic-no_periods_or_chars.logo" >> |
| 11 |
> > logo_config echo "./logos/classic.logo" >> logo_config |
| 12 |
> |
| 13 |
> cat >> logo_config <<-EOF will look much better here. |
| 14 |
|
| 15 |
src_prepare() { |
| 16 |
cat >> logo_config <<EOF |
| 17 |
line0 |
| 18 |
line1 |
| 19 |
line2 |
| 20 |
line3 |
| 21 |
EOF |
| 22 |
} |
| 23 |
|
| 24 |
Since I like indenting, I don't think so. Using FILESDIR is probably |
| 25 |
better, as mgorny suggested. |
| 26 |
|
| 27 |
> |
| 28 |
> > cp "${FILESDIR}"/gentoo{,2}.logo "${S}"/logos/ |
| 29 |
> |
| 30 |
> || die |
| 31 |
|
| 32 |
|
| 33 |
Good catch. |
| 34 |
|
| 35 |
> > echo "NAME gentoo" >> "${S}"/logos/gentoo.logo |
| 36 |
> > } |
| 37 |
> > |
| 38 |
> > src_compile() { |
| 39 |
> > ARCH="" ./configure --prefix="${D}"/usr || die |
| 40 |
> |
| 41 |
> Why not src_configure()? |
| 42 |
> Also use econf or add # some comment here, please. |
| 43 |
|
| 44 |
Legacy. |
| 45 |
|
| 46 |
> > cp "${FILESDIR}"/${PN}.conf "${WORKDIR}" |
| 47 |
> > sed -i -e 's/-L 4 -f -u/-f -u/' "${WORKDIR}"/${PN}.conf |
| 48 |
> |
| 49 |
> || die |
| 50 |
|
| 51 |
Yes. |
| 52 |
|
| 53 |
|
| 54 |
jer |
Archives