Gentoo Archives: gentoo-dev

From: Pacho Ramos <pacho@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] autotools.eclass no longer inherits eutils; check your ebuilds!
Date: Tue, 22 May 2012 18:23:48
Message-Id: 1337710935.24288.7.camel@belkin4
In Reply to: Re: [gentoo-dev] autotools.eclass no longer inherits eutils; check your ebuilds! by Zac Medico
El lun, 21-05-2012 a las 12:25 -0700, Zac Medico escribió:
> On 05/21/2012 12:04 PM, Pacho Ramos wrote: > > El lun, 21-05-2012 a las 13:46 -0400, Alexandre Rostovtsev escribió: > >> On May 20, autools.eclass was changed to no longer inherit eutils, see > >> http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/autotools.eclass?r1=1.133&r2=1.134 > >> > >> Relying on autotools.eclass for your eutils needs was always a terrible > >> idea, but a few ebuilds did it anyway. Those ebuilds are now *broken* > >> since they can no longer use epatch. See bug #416847 for an example. > >> > >> Check your ebuilds to make sure you inherit eutils in anything that uses > >> epatch! > >> > >> -Alexandre Rostovtsev. > >> > >> > >> > > > > Looks like ebuilds not inheriting eutils directly even using epatch are > > a lot as I have seen running: > > grep inherit $(grep -r epatch */*/*.ebuild| cut -d: -f1) | grep -v > > eutils > > > > Maybe they should be checked and a repoman warning should be added when > > an ebuild is using epatch without inheriting eutils directly, otherwise > > this problem could reappear if some other eclass no longer inherit it in > > the future :-/ > > Yeah, we have a similar check for inherit of prefix.eclass: > > http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=b583812101f1156c553385effcd9dbee0b751087
Should we (I) open a bug report requesting that or this is enough as report? Thanks :)

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies