Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 2/3] libtool.eclass: Use app-portage/elt-patches to provide patch files
Date: Fri, 17 Mar 2017 20:11:24
Message-Id: 1489781462.1490.9.camel@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH 2/3] libtool.eclass: Use app-portage/elt-patches to provide patch files by Mike Gilbert
1 On pią, 2017-03-17 at 15:47 -0400, Mike Gilbert wrote:
2 > On Fri, Mar 17, 2017 at 2:48 PM, Michał Górny <mgorny@g.o> wrote:
3 > > ---
4 > > eclass/libtool.eclass | 14 +++-----------
5 > > 1 file changed, 3 insertions(+), 11 deletions(-)
6 > >
7 > > diff --git a/eclass/libtool.eclass b/eclass/libtool.eclass
8 > > index a8df6ca58fef..037a6a2734df 100644
9 > > --- a/eclass/libtool.eclass
10 > > +++ b/eclass/libtool.eclass
11 > > @@ -16,18 +16,10 @@
12 > > if [[ -z ${_LIBTOOL_ECLASS} ]]; then
13 > > _LIBTOOL_ECLASS=1
14 > >
15 > > -# If an overlay has eclass overrides, but doesn't actually override the
16 > > -# libtool.eclass, we'll have ECLASSDIR pointing to the active overlay's
17 > > -# eclass/ dir, but libtool.eclass is still in the main Gentoo tree. So
18 > > -# add a check to locate the ELT-patches/ regardless of what's going on.
19 > > -# Note: Duplicated in eutils.eclass.
20 > > -_LIBTOOL_ECLASSDIR_LOCAL=${BASH_SOURCE[0]%/*}
21 > > +DEPEND=">=app-portage/elt-patches-20170317"
22 > > +
23 > > libtool_elt_patch_dir() {
24 > > - local d="${ECLASSDIR}/ELT-patches"
25 > > - if [[ ! -d ${d} ]] ; then
26 > > - d="${_LIBTOOL_ECLASSDIR_LOCAL}/ELT-patches"
27 > > - fi
28 > > - echo "${d}"
29 > > + echo /usr/share/elt-patches
30 >
31 > I think this should probably be "${EPREFIX}/usr/share/elt-patches".
32
33 Makes sense. Do we still do the 'use prefix' hoops for old EAPIs, or
34 just ${EPREFIX} these days?
35
36 --
37 Best regards,
38 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies