Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] eutils.eclass: Deprecate validate_desktop_entries
Date: Sat, 18 Mar 2017 07:34:53
Message-Id: 1489822460.1289.2.camel@gentoo.org
In Reply to: [gentoo-dev] [PATCH] eutils.eclass: Deprecate validate_desktop_entries by "Michał Górny"
1 On sob, 2017-03-11 at 14:06 +0100, Michał Górny wrote:
2 > The validate_desktop_entries function is redundant to the built-in
3 > .desktop file checks done by Portage directly. It is used in total by
4 > two packages for both of which bugs have been filed.
5 > ---
6 > eclass/eutils.eclass | 3 +++
7 > 1 file changed, 3 insertions(+)
8 >
9 > diff --git a/eclass/eutils.eclass b/eclass/eutils.eclass
10 > index e398aafc464a..d91245495caa 100644
11 > --- a/eclass/eutils.eclass
12 > +++ b/eclass/eutils.eclass
13 > @@ -883,6 +883,9 @@ _eutils_eprefix_init() {
14 > # @DESCRIPTION:
15 > # Validate desktop entries using desktop-file-utils
16 > validate_desktop_entries() {
17 > + eqawarn "validate_desktop_entries is deprecated and should be not be used."
18 > + eqawarn ".desktop file validation is done implicitly by Portage now."
19 > +
20 > _eutils_eprefix_init
21 > if [[ -x "${EPREFIX}"/usr/bin/desktop-file-validate ]] ; then
22 > einfo "Checking desktop entry validity"
23
24 Committed.
25
26 --
27 Best regards,
28 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature