Gentoo Archives: gentoo-dev

From: Arfrever Frehtes Taifersar Arahesis <Arfrever@g.o>
To: Gentoo Development <gentoo-dev@l.g.o>
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-python/traits: traits-3.4.0.ebuild
Date: Sun, 20 Jun 2010 13:57:16
Message-Id: 201006201556.14340.Arfrever@gentoo.org
In Reply to: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-python/traits: traits-3.4.0.ebuild by Mike Frysinger
1 2010-06-19 22:53:37 Mike Frysinger napisał(a):
2 > On Thursday, June 10, 2010 16:45:29 Arfrever Frehtes Taifersar Arahesis wrote:
3 > > 2010-06-10 22:20:44 Nirbheek Chauhan napisał(a):
4 > > > On Fri, Jun 11, 2010 at 1:30 AM, Arfrever Frehtes Taifersar wrote:
5 > > > > 2010-06-10 21:27:40 Jeremy Olexa napisał(a):
6 > > > >> I see no reason to *not* add a ChangeLog entry here.
7 > > > >
8 > > > > ChangeLog entries are not required for trivial changes.
9 > > >
10 > > > A "trivial" change is fixing a typo, or a manifest problem, a missing
11 > > > quotation mark, etc. Anything else is not "trivial".
12 > > >
13 > > > Anything that changes how an ebuild functions, what it does, or the
14 > > > installed files (and/or their contents) is NOT a trivial change.
15 > >
16 > > This commit only removed some compiler warnings.
17 >
18 > mucking with CFLAGS without documentation is wrong. compiler warnings come
19 > and go, so a flag that was relevant one day could be completely extraneous the
20 > next.
21 >
22 > however, especially with strict aliasing, you arent "just fixing warnings",
23 > you're changing optimization behavior of gcc to workaround broken C code.
24 > this obviously does not fall anywhere near the "trivial" mark.
25 >
26 > i see you still havent fixed this, so get on it already. a bug needs to be
27 > opened somewhere to get the package properly *fixed*
28
29 This problem is probably caused by bugs in Python 2, which have been fixed in Python 3.
30
31 $ echo 'a = True' > test.pyx
32 $ cython test.pyx
33 $ gcc -O2 -Wall -I/usr/include/python3.1 -c test.c
34 $ gcc -O2 -Wall -I/usr/include/python2.6 -c test.c
35 test.c: In function ‘inittest’:
36 test.c:479: warning: dereferencing type-punned pointer will break strict-aliasing rules
37 test.c:479: warning: dereferencing type-punned pointer will break strict-aliasing rules
38 test.c:479: warning: dereferencing pointer ‘_Py_TrueStruct.42’ does break strict-aliasing rules
39 test.c:479: warning: dereferencing pointer ‘_Py_TrueStruct.42’ does break strict-aliasing rules
40 test.c:479: note: initialized from here
41 test.c:482: warning: dereferencing pointer ‘__pyx_t_1’ does break strict-aliasing rules
42 test.c:482: warning: dereferencing pointer ‘__pyx_t_1’ does break strict-aliasing rules
43 test.c:482: warning: dereferencing pointer ‘__pyx_t_1’ does break strict-aliasing rules
44 test.c:482: warning: dereferencing pointer ‘__pyx_t_1’ does break strict-aliasing rules
45 test.c:479: note: initialized from here
46
47 --
48 Arfrever Frehtes Taifersar Arahesis

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies