Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: kensington@g.o
Subject: Re: [gentoo-dev] Patch: Linguas USE support for cmake-utils.eclass
Date: Sat, 23 Jun 2012 17:56:24
Message-Id: 20120623195703.39648ba6@pomiocik.lan
In Reply to: [gentoo-dev] Patch: Linguas USE support for cmake-utils.eclass by Michael Palimaka
1 On Sun, 24 Jun 2012 03:37:59 +1000
2 Michael Palimaka <kensington@g.o> wrote:
3
4 > --- cmake-utils.eclass
5 > +++ cmake-utils.eclass
6 > @@ -20,0 +21,29 @@
7 > +# @ECLASS-VARIABLE: LANGS
8
9 Please prefix.
10
11 > +# @DEFAULT_UNSET
12 > +# @DESCRIPTION:
13 > +# In case your application provides various translations, use this
14 > variable to specify
15 > +# them in order to populate "linguas_*" IUSE automatically. Make
16 > sure that you set this
17 > +# variable before inheriting cmake-utils eclass.
18 > +# Example:
19 > +# @CODE
20 > +# LANGS="en el de"
21 > +# @CODE
22 > +for x in ${LANGS}; do
23 > + IUSE+=" linguas_${x}"
24 > +done
25 > +
26 > +# @ECLASS-VARIABLE: LANGSLONG
27 > +# @DEFAULT_UNSET
28 > +# @DESCRIPTION:
29 > +# Same as above, but this variable is for LINGUAS that must be in
30 > long format.
31 > +# Remember to set this variable before inheriting cmake-utils eclass.
32 > +# Look at ${PORTDIR}/profiles/desc/linguas.desc for details.
33 > +# Example:
34 > +# @CODE
35 > +# LANGS="de_DE hu_HU"
36 > +# @CODE
37
38 Shouldn't this be LANGSLONG?
39
40 > +for x in ${LANGSLONG}; do
41 > + IUSE+=" linguas_${x%_*}"
42 > +done
43 > +unset x
44 > +
45
46 And how does it exactly differ from LANGS above? Is there a reason
47 those two can't be coerced into a single variable?
48
49 Shouldn't those do something more than setting IUSE? For example,
50 actually ensuring those LINGUAS will be installed?
51
52
53 --
54 Best regards,
55 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies