Gentoo Archives: gentoo-dev

From: Tim Harder <radhermit@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: app-admin/needrestart/
Date: Mon, 09 Mar 2020 18:13:48
Message-Id: 20200309181339.GA10636@sumac.radhermit.com
In Reply to: Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: app-admin/needrestart/ by Joonas Niilola
1 On 2020-03-09 Mon 10:42, Joonas Niilola wrote:
2 > >
3 > > Removal of that version was a mistake. Thank you for pointing it out.
4 > >
5 > > Here's the commit re-adding it:
6 > > https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f3fa1c548
7 > >
8 > > I checked, and repoman doesn't seem to be warning about removing the
9 > > last stable version of a package.
10 > >
11 > > ~Craig
12
13 > Neither does pkgcheck for what it's worth. Unless the removal causes a
14 > situation where there are unsatisfied revdeps left.
15
16 That's not correct. If `pkgcheck scan --commits` had been used locally
17 before pushing this would have shown a DroppedStableKeywords result
18 pointing to the commit (if it didn't that's a bug). There is also
19 DroppedUnstableKeywords for dropped ~arch keywords.
20
21 To reiterate, pkgcheck must be used locally for scanning unpushed git
22 commits to flag these cases, CI won't catch them.
23
24 Tim