| 1 |
On Thu, 29 Jun 2017 14:37:49 -0700 |
| 2 |
Matt Turner <mattst88@g.o> wrote: |
| 3 |
|
| 4 |
> On Thu, Jun 29, 2017 at 2:19 PM, James Le Cuirot <chewi@g.o> wrote: |
| 5 |
> > On Wed, 28 Jun 2017 23:29:03 +0100 |
| 6 |
> > James Le Cuirot <chewi@g.o> wrote: |
| 7 |
> > |
| 8 |
> >> > On Tue, Jun 27, 2017 at 6:44 PM, James Le Cuirot <chewi@g.o> wrote: |
| 9 |
> >> > > I am therefore proposing a new global big-endian flag. This could be |
| 10 |
> >> > > masked by default and unmasked + forced in the relevant profiles under |
| 11 |
> >> > > arch. I will apply this according to the mapping defined in tc-endian of |
| 12 |
> >> > > toolchain-funcs.eclass. |
| 13 |
> >> |
| 14 |
> >> I've just been putting the patch together. I made it slightly simpler |
| 15 |
> >> by masking *and* forcing it by default so that it only needs to be |
| 16 |
> >> unmasked were necessary. |
| 17 |
> > |
| 18 |
> > Feedback seems positive so here is the patch. I'll apply it late next |
| 19 |
> > week as I don't need it immediately and I will be away until then. |
| 20 |
> > |
| 21 |
> > --- |
| 22 |
> > |
| 23 |
> > diff --git a/profiles/arch/alpha/use.mask b/profiles/arch/alpha/use.mask |
| 24 |
> > index d488fe8a09f4..b17afe9d9d4d 100644 |
| 25 |
> > --- a/profiles/arch/alpha/use.mask |
| 26 |
> > +++ b/profiles/arch/alpha/use.mask |
| 27 |
> > @@ -1,6 +1,10 @@ |
| 28 |
> > # Copyright 1999-2017 Gentoo Foundation. |
| 29 |
> > # Distributed under the terms of the GNU General Public License, v2 |
| 30 |
> > |
| 31 |
> > +# James Le Cuirot <chewi@g.o> (29 Jun 2017) |
| 32 |
> > +# Unmask as this profile is big endian. |
| 33 |
> > +-big-endian |
| 34 |
> |
| 35 |
> No. Alpha is little endian. |
| 36 |
|
| 37 |
Wikipedia says it is bi. tc-native() reports alpha* as big so I guess |
| 38 |
that's the only variant we support? Then again, this page says it is |
| 39 |
usually little. Is tc-native() wrong? |
| 40 |
|
| 41 |
https://kernelnewbies.org/EndianIssues |
| 42 |
|
| 43 |
> > --- /dev/null |
| 44 |
> > +++ b/profiles/arch/mips/mipsel/use.mask |
| 45 |
> > @@ -0,0 +1,6 @@ |
| 46 |
> > +# Copyright 1999-2017 Gentoo Foundation |
| 47 |
> > +# Distributed under the terms of the GNU General Public License v2 |
| 48 |
> > + |
| 49 |
> > +# James Le Cuirot <chewi@g.o> (29 Jun 2017) |
| 50 |
> > +# Remask as this profile is little endian. |
| 51 |
> > +big-endian |
| 52 |
> > diff --git a/profiles/arch/mips/use.mask b/profiles/arch/mips/use.mask |
| 53 |
> > index 09ac8ca4b2cc..6caff81617cb 100644 |
| 54 |
> > --- a/profiles/arch/mips/use.mask |
| 55 |
> > +++ b/profiles/arch/mips/use.mask |
| 56 |
> > @@ -4,6 +4,10 @@ |
| 57 |
> > # Unmask the flag which corresponds to ARCH. |
| 58 |
> > -mips |
| 59 |
> > |
| 60 |
> > +# James Le Cuirot <chewi@g.o> (29 Jun 2017) |
| 61 |
> > +# Unmask as this profile is big endian. |
| 62 |
> > +-big-endian |
| 63 |
> |
| 64 |
> I'm not sure if this one is correct. arch/mips/mipsel's 'parent' file |
| 65 |
> contains '..' |
| 66 |
> |
| 67 |
> I think if you re-mask big-endian in arch/mips/mipsel it'll work, and |
| 68 |
> that seems like the best way to solve it. |
| 69 |
|
| 70 |
That's what I did? |
Archives