Gentoo Archives: gentoo-dev

From: hasufell <hasufell@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Re: enhancement for doicon/newicon in eutils.eclass
Date: Sat, 02 Jun 2012 02:54:01
Message-Id: 4FC97F62.2030206@gentoo.org
In Reply to: Re: [gentoo-dev] Re: enhancement for doicon/newicon in eutils.eclass by Mike Frysinger
On 06/02/2012 12:49 AM, Mike Frysinger wrote:
> On Wednesday 23 May 2012 21:04:42 hasufell wrote: >> # @FUNCTION: _iconins >> # @DESCRIPTION: >> # function for use in doicon and newicon > > mark it @INTERNAL > >> if [[ -z $size ]] ; then > > ${size} > >> if [[ $function == doicon ]] ; then > > ${function} > >> if [[ $function == newicon ]] ; then > > ${function} > >> doicon() { >> local function=$FUNCNAME >> _iconins "$@" > > passing the funcname in this way is kind of ugly. you could do: > _iconins ${FUNCNAME} "$@" > > and then at the top of _iconins: > local funcname=$1; shift > > i guess if we all agree this complication is useful, then fix the nits and > let's merge it > -mike
Yo, I hope this is it. Haven't seen many arguments against it as it is an optional feature anyway. Anyone got reservations left?

Attachments

File name MIME type
eutils.eclass.02jun text/plain

Replies