Gentoo Archives: gentoo-dev

From: Samuli Suominen <ssuominen@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] ebuild laziness and binpkg overhead
Date: Fri, 15 Jun 2012 07:49:43
Message-Id: 4FDAE7CE.7080703@gentoo.org
In Reply to: [gentoo-dev] ebuild laziness and binpkg overhead by Mike Frysinger
On 06/13/2012 06:02 AM, Mike Frysinger wrote:
> i've noticed a growing trend where people put setup of variables into > pkg_setup that only matter to src_* funcs presumably so they don't have to > call the respective src_* func from an inherited eclass. unfortunately this > adds pointless overhead to binpkgs. can we please move away from this > practice ? > > i've seen this with a good number of the GNOME packages like: > pkg_setup() { > G2CONF="${G2CONF} > --disable-bash-completion > --disable-hal > --disable-schemas-compile > --with-dbus-service-dir=/usr/share/dbus-1/services > $(use_enable afp) > $(use_enable archive) > $(use_enable avahi) > $(use_enable bluetooth obexftp) > $(use_enable bluray) > $(use_enable cdda) > $(use_enable fuse) > $(use_enable gdu) > $(use_enable gphoto2) > $(use_enable ios afc) > $(use_enable udev) > $(use_enable udev gudev) > $(use_enable http) > $(use_enable gnome-keyring keyring) > $(use_enable samba)" > } > > ugh > -mike >
Every Xfce ebuild in gentoo-x86 is using pkg_setup() for 3 variables, DOCS for src_install, PATCHES for src_prepare, and XFCONF for src_configure No way we will add all 3 phases to every Xfce ebuild since that would defeat the purpose of the xfconf.eclass which is designed so that we cope with 99,0% using just pkg_setup() Using all 3 vars would also likely mean that the diff's for xfce-overlay for 9999 ebuilds would increase to "unmaintainable stage" (the 9999 ebuilds are generated from gentoo-x86, not the otherway around) The pros overweight the cons * N - Samuli

Replies

Subject Author
Re: [gentoo-dev] ebuild laziness and binpkg overhead Luca Barbato <lu_zero@g.o>
Re: [gentoo-dev] ebuild laziness and binpkg overhead Mike Frysinger <vapier@g.o>
Re: [gentoo-dev] ebuild laziness and binpkg overhead Samuli Suominen <ssuominen@g.o>