[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: depend.apache.eclass

[Donnie Berkholz]

On 21:20 Wed 06 Feb     , Benedikt Boehm (hollow) wrote:
> Revision  Changes    Path
> 1.42                 eclass/depend.apache.eclass
>
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/depend.apache.eclass?rev=1.42&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/depend.apache.eclass?rev=1.42&content-type=text/plain
> diff : http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/depend.apache.eclass?r1=1.41&r2=1.42

> +check_apache_threads_in() {

"check_" is a really poor function prefix, because it doesn't tell you 
whether it returns success for when threads exist or returns success for 
when it's unthreaded. Rename this something like "has_apache_threads" 
instead.

> +	debug-print-function $FUNCNAME $*
> +
> +	if ! built_with_use www-servers/apache threads ; then
> +		return
> +	fi
> +
> +	local myforeign="$1"
> +	local myflag="${2:-threads}"
> +
> +	if ! built_with_use ${myforeign} ${myflag} ; then
> +		echo
> +		eerror "You need to enable USE flag '${myflag}' in ${myforeign} to"
> +		eerror "build a thread-safe version of ${CATEGORY}/${PN} for use"
> +		eerror "with www-servers/apache"
> +		die "Need missing USE flag '${myflag}' in ${myforeign}"
> +	fi
> +}

Thanks,
Donnie
-- 
gentoo-dev@l.g.o mailing list