Gentoo Archives: gentoo-dev

From: Mike Gilbert <floppym@g.o>
To: Ulrich Mueller <ulm@g.o>
Cc: Gentoo Dev <gentoo-dev@l.g.o>
Subject: Re: [gentoo-dev] [PATCH v2] python-utils-r1.eclass: avoid nested ebegin calls
Date: Mon, 11 Jul 2022 18:14:34
Message-Id: CAJ0EP40rmQo+tzxvoigfH-tT+4jXNuJitKTOsGCvt-JT4buLZQ@mail.gmail.com
In Reply to: Re: [gentoo-dev] [PATCH v2] python-utils-r1.eclass: avoid nested ebegin calls by Ulrich Mueller
1 On Mon, Jul 11, 2022 at 1:57 PM Ulrich Mueller <ulm@g.o> wrote:
2 >
3 > >>>>> On Mon, 11 Jul 2022, Mike Gilbert wrote:
4 >
5 > >> Maybe leave ebegin/eend in place then, which was invented precisely for
6 > >> this use case? What's so bad about nesting it?
7 >
8 > > It leads to odd looking output.
9 >
10 > > https://gitweb.gentoo.org/proj/portage.git/commit/?id=eba088af8f335c0adb386461e6df1267e24800e7
11 >
12 > IIUC it would look like this, with the patch applied:
13 >
14 > * task 1
15 > * Doing task 2 ... [ ok ]
16 > * task 1 succeeded
17 >
18 > That's not the most beautiful of outputs either.
19
20 Right. I would prefer to apply the first patch I submitted instead.

Replies

Subject Author
Re: [gentoo-dev] [PATCH v2] python-utils-r1.eclass: avoid nested ebegin calls Frederik Pfautsch <frederik.pfautsch@×××××××.de>