Gentoo Archives: gentoo-dev

From: Fabian Groffen <grobian@g.o>
To: gentoo-dev@l.g.o, Arfrever Frehtes Taifersar Arahesis <arfrever.fta@×××××.com>
Subject: [gentoo-dev] Re: proj/portage:master commit in: pym/portage/dbapi/
Date: Sat, 26 Nov 2011 10:59:05
Message-Id: 20111126105822.GA37825@gentoo.org
Attempt 2 from correct email address, sorry for any duplicate in
advance.

On 26-11-2011 01:54:35 +0000, Arfrever Frehtes Taifersar Arahesis wrote:
> commit: 1d4ac47c28706094230cb2c4e6ee1c1c71629aa0 > T> Org> > AuthorDate: Sat Nov 26 01:52:49 2011 +0000 > Commit: Arfrever Frehtes Taifersar Arahesis <arfrever <AT> gentoo <DOT> org> > CommitDate: Sat Nov 26 01:52:49 2011 +0000 > URL: http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=1d4ac47c > > dblink.mergeme(): Merge files in alphabetic order.
What's the advantage of this? I don't really like to pay for sorting a potentially huge list just for some eye-candy. (That's omitted by default these days anyway...) Any other opinions on this one?
> --- > pym/portage/dbapi/vartree.py | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/pym/portage/dbapi/vartree.py b/pym/portage/dbapi/vartree.py > index dd74c10..099164a 100644 > --- a/pym/portage/dbapi/vartree.py > +++ b/pym/portage/dbapi/vartree.py > @@ -3981,7 +3981,7 @@ class dblink(object): > mergelist = stufftomerge > offset = "" > > - for i, x in enumerate(mergelist): > + for i, x in enumerate(sorted(mergelist)): > > mysrc = join(srcroot, offset, x) > mydest = join(destroot, offset, x) >
-- Fabian Groffen Gentoo on a different level

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
[gentoo-dev] Re: proj/portage:master commit in: pym/portage/dbapi/ Arfrever Frehtes Taifersar Arahesis <arfrever@g.o>
Re: [gentoo-dev] Re: proj/portage:master commit in: pym/portage/dbapi/ Nirbheek Chauhan <nirbheek@g.o>