1 |
On 15:16 Sat 29 Mar , Richard Brown (rbrown) wrote: |
2 |
> 1.1 dev-ruby/rubygems/rubygems-1.1.0-r0.ebuild |
3 |
> |
4 |
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-ruby/rubygems/rubygems-1.1.0-r0.ebuild?rev=1.1&view=markup |
5 |
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-ruby/rubygems/rubygems-1.1.0-r0.ebuild?rev=1.1&content-type=text/plain |
6 |
> |
7 |
> Index: rubygems-1.1.0-r0.ebuild |
8 |
|
9 |
What was the purpose of bumping this to an -r0? I didn't see any |
10 |
previous rubygems ebuilds doing this. |
11 |
|
12 |
I'm probably wrong about this, but my naive impression is that it looks |
13 |
to me like an attempt to force someone else to bring up the issue that |
14 |
indeed did come up, rather than doing it yourself. |
15 |
|
16 |
> dosym /usr/bin/gem18 /usr/bin/gem || die "dosym gem failed" |
17 |
|
18 |
No big deal, but it would be nice to do a relative symlink here. |
19 |
|
20 |
> #This is used to update rubygems, do not want. |
21 |
> rm "${D}/usr/bin/update_rubygems18" |
22 |
> |
23 |
> dodoc README |
24 |
> if use examples; then |
25 |
> cp -pPR examples "${D}/usr/share/doc/${PF}" |
26 |
> fi |
27 |
> |
28 |
> cp "${FILESDIR}/auto_gem.rb" "${D}"/$(${RUBY} -r rbconfig -e 'print Config::CONFIG["sitedir"]') |
29 |
> doenvd "${FILESDIR}/10rubygems" |
30 |
> |
31 |
> if use server; then |
32 |
> newinitd "${FILESDIR}/init.d-gem_server" gem_server |
33 |
> newconfd "${FILESDIR}/conf.d-gem_server" gem_server |
34 |
> fi |
35 |
|
36 |
Might be nice to die if some of these fail. |
37 |
|
38 |
> } |
39 |
> |
40 |
> pkg_postinst() |
41 |
> { |
42 |
> ver=$(${RUBY} -r rbconfig -e 'print Config::CONFIG["ruby_version"]') |
43 |
|
44 |
Shouldn't this be preserved in the environment from src_install()? Rerunning it seems like |
45 |
it could allow a change in ruby version to cause issues. |
46 |
|
47 |
Thanks, |
48 |
Donnie |
49 |
-- |
50 |
gentoo-dev@l.g.o mailing list |