Re: [gentoo-dev] Time to Stop and Clean

[Spider]

begin  quote
On Sat, 15 Nov 2003 13:16:13 +0000
Stroller <root@××××××××××××××××××.uk> wrote:

>
> On Nov 13, 2003, at 3:28 pm, Spider wrote:
>
> > begin  quote
> > On Wed, 12 Nov 2003 18:46:13 -0500
> > Aron Griffis <agriffis@g.o> wrote:
> >
> >> Spider wrote:	[Sun Nov 09 2003, 07:02:38PM EST]
> >>> Could all ye developers take the time to go through your packages
> >>> and
> >>> check that there are -no- references to ${D} ${S} , ${W} in pkg_*
> >>> statements?
> >>
> >> All the offenders (assuming this is actually an offense):
> >
> >
> > More interesting examples:
> > ./net-news/leafnode/leafnode-2.0.0_alpha20030621.ebuild
> > pkg_postinst() {
> > 	mkdir -p
> > /var/spool/news/
> > {leaf.node,failed.postings,interesting.groups,out.going}
> > 	mkdir -p
> > /var/spool/news/message.id/{0,1,2,3,4,5,6,7,8,9}{0,1,2,3,4,5,6,7,8,
> > 9}{0
> > ,1,2,3,4,5,6,7,8,9}
> > 	chown -R news:news /var/spool/news
>
> I think the Leafnode2 eBuild is broken, anyway. It seems to install
> into /var/lib/spool/news/
> See <http://bugs.gentoo.org/show_bug.cgi?id=25713> - I have attached a
>
> copy of the ebuild which seems to work here.
>

Proposed version still has theese lines :

	cat ${S}/README_FIRST | while read line ;
	do
		einfo $line
	done


And when you build packages, you never unpack the source, therefore ${S}
will not reference to any place where README_FIRST is.

do zcat ${ROOT}/usr/share/doc/${P}/README_FIRST.gz  instead.


And your "mkdir -p" lines are also broken, as theese will fail if I
expose ROOT for installation to some system that isn't / (also for
package installation)

theese should refer to ${ROOT}/var/spool ....

(check baselayout for a good example of things to do or not do)

Anyhow, is there a good reason why you create theese in the pkg_ part
instead of in src_install after you have done the main installation?  
I'd consider this broken behaviour, as any special case isn't documented
in the build either.


try "dodir
${D}/var/spool/news/message.id/{0,1,2,3,4,5,6,7,8,9}{0,1,2,3,4,5,6,7,8,
9}{0,1,2,3,4,5,6,7,8,9}"  instead




//Spider






-- 
begin  .signature
This is a .signature virus! Please copy me into your .signature!
See Microsoft KB Article Q265230 for more information.
end