| 1 |
>>>>> On Tue, 30 Sep 2008, Petteri Räty wrote: |
| 2 |
|
| 3 |
>>> dodoc ${DOCS} || die "dodoc failed" |
| 4 |
>> This seems alright fine to me |
| 5 |
|
| 6 |
> It's not. If you want to have default DOCS then you should loop |
| 7 |
> through the items and check with [[ -e ]] before trying to install |
| 8 |
> them. |
| 9 |
|
| 10 |
I'm not convinced that this is a good idea. Then you won't catch cases |
| 11 |
where upstream removes or renames files. |
| 12 |
|
| 13 |
Besides, dodoc already checks for -e by itself (and emits a warning if |
| 14 |
the file does not exist). |
| 15 |
|
| 16 |
So, maybe just do a 'dodoc "${DOCS}"' and omit the die? Then it won't |
| 17 |
fail but the warning message would be preserved. |
| 18 |
|
| 19 |
Ulrich |
Archives