1 |
On 09/13/2018 07:36 AM, Richard Yao wrote: |
2 |
> |
3 |
> |
4 |
>> On Sep 12, 2018, at 6:55 PM, Thomas Deutschmann <whissi@g.o> wrote: |
5 |
>> |
6 |
>>> On 2018-09-12 16:50, Rich Freeman wrote: |
7 |
>>> There is also the case where we want these warnings to block |
8 |
>>> installation, because the risk of there being a problem is too great. |
9 |
>> |
10 |
>> I really disagree with that. So many devs have already said multiple |
11 |
>> times in this thread that "-Werror" is only turning existing warnings |
12 |
>> into fatal errors but "-Werror" itself doesn't add any new checks and |
13 |
>> more often requires "-O3" to be useful. |
14 |
> The way that compilers work is that the warnings are generated in the front end while the optimization level affects the backend. That means that -O3 has no effect on the code that does error generation. This remark about -O3 being needed to make -Werror useful is just plain wrong. |
15 |
I had a discussion off list about this. My remarks on this were |
16 |
incorrect. However, I strongly disagree that -O3 is necessary for |
17 |
diagnostics to be useful. |
18 |
>> So let's turn this around: Please show us a *real* case within Gentoo |
19 |
>> where "-Werror" prevented a real problem which wouldn't otherwise being |
20 |
>> noticed. E.g. show us a package which was merged on user's system, |
21 |
>> replacing a working previous version of that package causing *real* |
22 |
>> problems which could have been prevented if package would have set |
23 |
>> "-Werror". |
24 |
>> |
25 |
>> Unless you can do that we don't really need to discuss this. Simply |
26 |
>> because everyone interested in "-Werror" *can* set that flag via CFLAGS, |
27 |
>> even just per package, whereas the majority, not interested in this, |
28 |
>> cannot do the same to filter "-Werror". Nobody advocating for "-Werror" |
29 |
>> replied to that fact yet. |
30 |
>> |
31 |
>> |
32 |
>> -- |
33 |
>> Regards, |
34 |
>> Thomas Deutschmann / Gentoo Linux Developer |
35 |
>> C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5 |
36 |
>> |
37 |
> |
38 |
> |