Gentoo Archives: gentoo-dev

From: Arfrever Frehtes Taifersar Arahesis <Arfrever@g.o>
To: Gentoo Development <gentoo-dev@l.g.o>
Subject: Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass
Date: Mon, 05 Jul 2010 23:32:24
Message-Id: 201007060132.00729.Arfrever@gentoo.org
In Reply to: Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass by Mike Frysinger
2010-07-06 00:29:09 Mike Frysinger napisał(a):
> On Monday, July 05, 2010 16:23:50 Arfrever Frehtes Taifersar Arahesis wrote: > > 2010-07-05 21:18:57 Mark Loeser napisał(a): > > > Arfrever Frehtes Taifersar Arahesis said: > > > > 2010-07-05 20:00:11 Mark Loeser napisał(a): > > > > > Everyone else has already made valid points. I'm just picking this > > > > > one to reply to now. Please remove the colors you have added. If > > > > > you need a new function, say "eqawarn", we should have that added in > > > > > the next EAPI with a description of when and where to use it. > > > > > > > > In case of the colored message added in this patch, if > > > > einfo/elog/ewarn/eqawarn/eerror was used, then its output wouldn't be > > > > logged by Portage. > > > > > > I don't understand what you are trying to say. > > > > Portage doesn't log output of einfo/elog/ewarn/eqawarn/eerror called in > > global scope. > > dont call it in global scope then. the more parsing you do in global scope > the worse you make performance for the tree. these things get executed during > dependency generation which means it gets spammed even when not emerging. > > use pkg_setup or something similar like everyone else.
Only 84 ebuilds in the tree set NEED_PYTHON variable. NEED_PYTHON can be used only in EAPI <=2. python_pkg_setup() is optional in EAPI <=3. Exactly 0 ebuilds, which use NEED_PYTHON, also call python_pkg_setup(). EXPORT_FUNCTIONS wasn't ommitted during this calculation. There are over 27000 ebuilds in the tree. Performance penalty from <=84 ebuilds shouldn't be noticeable during `emerge --regen`. -- Arfrever Frehtes Taifersar Arahesis

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies