| 1 |
2010-09-20 03:45:14 Mike Frysinger napisał(a): |
| 2 |
> On Sunday, September 19, 2010 21:18:51 Arfrever Frehtes Taifersar Arahesis |
| 3 |
> wrote: |
| 4 |
> > -evaluated_PYTHONPATH="$(eval echo -n "${PYTHONPATH_template}")" |
| 5 |
> > +eval "evaluated_PYTHONPATH=\"${PYTHONPATH_template}\"" |
| 6 |
> |
| 7 |
> the quotes in the 2nd one are useless. this should work the same: |
| 8 |
> eval evaluated_PYTHONPATH=\"${PYTHONPATH_template}\" |
| 9 |
|
| 10 |
The quotes are required: |
| 11 |
|
| 12 |
$ PYTHONPATH_template="/usr/share/a b" |
| 13 |
$ eval "evaluated_PYTHONPATH=\"${PYTHONPATH_template}\"" |
| 14 |
$ echo "${evaluated_PYTHONPATH}" |
| 15 |
/usr/share/a b |
| 16 |
$ eval evaluated_PYTHONPATH=\"${PYTHONPATH_template}\" |
| 17 |
$ echo "${evaluated_PYTHONPATH}" |
| 18 |
/usr/share/a b |
| 19 |
|
| 20 |
> while you're in the process of cleaning things up, i know we dont have a rule |
| 21 |
> anywhere in terms of line length, but python.eclass has always struck me as a |
| 22 |
> file with incredibly excessive line length. comparing to other eclasses, it |
| 23 |
> has multiple lines in it longer than any single line in any other eclass. |
| 24 |
> |
| 25 |
> i normally develop in a terminal with 170 cols (which i think is larger than |
| 26 |
> average), so i'm pretty lenient, but even python.eclass exceeds that multiple |
| 27 |
> times if not running close to it. |
| 28 |
|
| 29 |
python.eclass has many nested checks, loops etc. |
| 30 |
|
| 31 |
-- |
| 32 |
Arfrever Frehtes Taifersar Arahesis |
Archives