Re: [gentoo-dev] [PATCH 1/7] xorg-2.eclass: drop autotools-utils

[Michał Górny]

On Sun, 17 Apr 2016 10:45:08 -0400
Mike Gilbert <floppym@g.o> wrote:

> On Sun, Apr 17, 2016 at 10:31 AM, Ian Stakenvicius <axs@g.o> wrote:
> >
> >
> > Sent from an iPhone, sorry for the HTML...
> >
> >> On Apr 17, 2016, at 10:13 AM, Mike Gilbert <floppym@g.o> wrote:
> >>
> >> @@ -487,10 +497,17 @@ xorg-2_src_configure() {
> >> xorg-2_src_compile() {
> >>    debug-print-function ${FUNCNAME} "$@"
> >>
> >> +    local makeargs=( "$@" )
> >> +
> >>    if [[ ${XORG_MULTILIB} == yes ]]; then
> >> -        autotools-multilib_src_compile "$@"
> >> +        if ! declare -f multilib_src_compile >/dev/null; then
> >> +            multilib_src_compile() {
> >> +                emake "${makeargs[@]}"
> >> +            }
> >> +        fi
> >> +        multilib-minimal_src_compile
> >>    else
> >> -        autotools-utils_src_compile "$@"
> >> +        emake "${makeargs[@]}"
> >>    fi
> >> }
> >
> > Does the src_compile code need to be as complex as this?  Why not just a 'if $XORG_MULTILIB ; then multilib-minimal_src_compile "$@"; else emake "$@"; fi '?
> >
> > ...or even 'default' instead of emake...?
>
> multilib-mininmal_src_compile and default_src_comple do not provide
> any method to pass arguments to emake. If I recall correctly, there is
> at least one ebuild that needs to do so.

I'd say the EAPI approach (employed by multilib-minimal as well) would
be to redefine multilib_src_compile() in that ebuild rather than
complexifying the generic case.

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>