[gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: app-office/calcurse/

[Andreas K. Huettel]

Reverted [QA]. For reasons see below.

Am Dienstag, 10. März 2020, 12:28:25 CET schrieb Patrice Clement:
> commit:     34217564ddc5cd46762ffdaeb217aabd905dec6a
> Author:     Patrice Clement <monsieurp <AT> gentoo <DOT> org>
> AuthorDate: Tue Mar 10 10:32:00 2020 +0000
> Commit:     Patrice Clement <monsieurp <AT> gentoo <DOT> org>
> CommitDate: Tue Mar 10 11:28:15 2020 +0000
> URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=34217564
>
> app-office/calcurse: version bump.
>
> Package-Manager: Portage-2.3.89, Repoman-2.3.20
> Signed-off-by: Patrice Clement <monsieurp <AT> gentoo.org>
>
>  app-office/calcurse/Manifest              |  1 +
>  app-office/calcurse/calcurse-4.5.0.ebuild | 47
> +++++++++++++++++++++++++++++++ 2 files changed, 48 insertions(+)
>
> diff --git a/app-office/calcurse/Manifest b/app-office/calcurse/Manifest
> index a709a800e0c..d61266faf9b 100644
> --- a/app-office/calcurse/Manifest
> +++ b/app-office/calcurse/Manifest
> @@ -1 +1,2 @@
>  DIST calcurse-4.4.0.tar.gz 620263 BLAKE2B
> 8fbe875f5e757ec3c11b9c23a994260403ee990bfcb3d4c41eefbf06a6db9e76cd5157e32b1
> 1c3fdc049896d5db3a9856862724902dab1cb48e0b00ef5df6f73 SHA512
> 43d30ad68bb39aaa9460644a691e66cbb15b9930737581583da65d00214c70fb1148a0edeca
> 4430abb7a5cef2821b0f4c6fdbed8188d9ea5da5fedc4f95fa07c +DIST
> calcurse-4.5.0.tar.gz 657976 BLAKE2B
> 5cad43340cb973d402c92b7963f9c13e46acbb2f802df2ab447221913daa6b28872a323b743
> bc31be0c7358ea8e7d51d08054c81f3376d3dc07f5837d41be45f SHA512
> 795eae7c62b89c733049f0c137da398ce3dd5fba78f9a2c323aacdf8b176cf37bd9d0768dbd
> ac0bb1cb64cd248b1d851efd059836fbbbdd9665fa47beff3b872
>
> diff --git a/app-office/calcurse/calcurse-4.5.0.ebuild
> b/app-office/calcurse/calcurse-4.5.0.ebuild new file mode 100644
> index 00000000000..46600edc61f
> --- /dev/null
> +++ b/app-office/calcurse/calcurse-4.5.0.ebuild
> @@ -0,0 +1,47 @@
> +# Copyright 1999-2020 Gentoo Authors
> +# Distributed under the terms of the GNU General Public License v2
> +
> +EAPI=7
> +
> +inherit autotools eutils multilib-minimal

eutils is not used anywhere.

> +
> +DESCRIPTION="a text-based calendar and scheduling application"
> +HOMEPAGE="https://calcurse.org/"
> +SRC_URI="https://calcurse.org/files/${P}.tar.gz"
> +
> +LICENSE="BSD-2"
> +SLOT="0"
> +KEYWORDS="~amd64 ~ppc ~ppc64 ~x86"
> +IUSE="doc"

Is that "doc" doing anything ...

> +
> +RDEPEND="
> +	dev-python/httplib2

As far as I can see, httplib2 installs only python packages specific for python 
versions, no utilities to be called from shell. How do you make sure that it's 
installed for currently active python?

> +	sys-libs/ncurses:0="
> +
> +DEPEND="
> +	${RDEPEND}
> +	doc? ( app-text/asciidoc )"

... except adding a DEPEND?
Also, with EAPI=7 asciidoc should probably be a BDEPEND.

> +
> +PATCHES=(
> +	"${FILESDIR}"/${PN}-4.2.1-tinfo.patch
> +)
> +
> +# Most tests fail.
> +RESTRICT="test"

is there an open bug about it?

> +
> +src_prepare() {
> +	default
> +	eautoreconf
> +}
> +

> +multilib_src_configure() {
> +	ECONF_SOURCE="${S}" econf
> +}
> +

Likely redundant.

> +src_compile() {
> +	multilib-minimal_src_compile
> +}
> +
> +src_install() {
> +	multilib-minimal_src_install
> +}

Completely pointless redefinition of src_compile and src_install (both are 
exported by multilib-minimal.eclass)...

-- 
Andreas K. Hüttel
dilfridge@g.o
Gentoo Linux developer 
(council, qa, toolchain, base-system, perl, libreoffice)