Gentoo Archives: gentoo-dev

From: Mike Frysinger <vapier@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] prune_libtool_files(): go into .a removal only when .a exists.
Date: Fri, 15 Jun 2012 20:09:14
Message-Id: 201206151608.11168.vapier@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH] prune_libtool_files(): go into .a removal only when .a exists. by "Michał Górny"
1 On Friday 15 June 2012 12:54:16 Michał Górny wrote:
2 > On Fri, 15 Jun 2012 11:11:44 -0400 Michael Orlitzky wrote:
3 > > On 06/15/12 09:32, Michał Górny wrote:
4 > > > It is a little confusing when the function reports .a removal when
5 > > > no such file exists. Also, explain why the file is removed.
6 > >
7 > > Why keep the "-f"?
8 >
9 > For rm?
10 >
11 > -f, --force
12 > ignore nonexistent files and arguments, never prompt
13 >
14 > The second part is still valid.
15
16 i think his point was that since you just did a [[ -f ]] test, there shouldn't
17 really be any cases where the rm would fail, so you could change the `rm -f`
18 to `rm || die` ...
19 -mike

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies