Gentoo Archives: gentoo-dev

From: Mike Gilbert <floppym@g.o>
To: Gentoo Dev <gentoo-dev@l.g.o>
Cc: Benda Xu <heroxbd@g.o>
Subject: Re: [gentoo-dev] [PATCH] fcaps.eclass: skip fcaps() on Prefix.
Date: Sun, 08 Mar 2020 15:42:12
Message-Id: CAJ0EP43jy9jRoNw7zmgSKPMjads2e0g_duwxHVKqCaiBL7G_SA@mail.gmail.com
In Reply to: [gentoo-dev] [PATCH] fcaps.eclass: skip fcaps() on Prefix. by heroxbd@gentoo.org
1 On Sun, Mar 8, 2020 at 5:20 AM <heroxbd@g.o> wrote:
2 >
3 > From: Benda Xu <heroxbd@g.o>
4 >
5 > Gentoo Prefix runs with a normal user and cannot grant extra
6 > capabilities. Exit gracefully with a message.
7 >
8 > Signed-off-by: Benda Xu <heroxbd@g.o>
9 > ---
10 > eclass/fcaps.eclass | 5 +++++
11 > 1 file changed, 5 insertions(+)
12 >
13 > diff --git a/eclass/fcaps.eclass b/eclass/fcaps.eclass
14 > index 467f955f5e9a..ddc4d3ccc6d8 100644
15 > --- a/eclass/fcaps.eclass
16 > +++ b/eclass/fcaps.eclass
17 > @@ -78,6 +78,11 @@ DEPEND="filecaps? ( sys-libs/libcap )"
18 > fcaps() {
19 > debug-print-function ${FUNCNAME} "$@"
20 >
21 > + if [[ ${EUID} != 0 ]] ; then
22 > + einfo "Insufficient privileges to execute ${FUNCNAME}, skip."
23 > + return 0
24 > + fi
25 > +
26
27 It seems like you are commanding the user to skip.
28
29 s/skip/skipping/

Replies