1 |
On Fri, Nov 26, 2021 at 12:55:10AM +0000, Sam James wrote: |
2 |
> |
3 |
> |
4 |
> > On 25 Nov 2021, at 17:07, Thomas Deutschmann <whissi@g.o> wrote: |
5 |
> > |
6 |
> > On 2021-11-25 18:01, Piotr Karbowski wrote: |
7 |
> >>> https://github.com/gentoo/gentoo/blob/master/sys-libs/glibc/glibc-2.34-r2.ebuild#L643 |
8 |
> >> Would you see something like this on more ebuilds, postgres, mysql, elasticsearch, or have proper FEATURE flag for it instead? |
9 |
> >> It's all cool and giggles until you realize that even such random variable is not even prefixed with PORTAGE_ or anything, meaning it could be taken out of shell and meant for entirely different thing. |
10 |
> > |
11 |
> > Yeah, sounds like the I_KNOW_WHAT_I_AM_DOING thing which you end up having enabled globally for various reasons. |
12 |
> |
13 |
> Just like updating in a cron job is a not-great idea, setting this globally and not per-package via /etc/portage/env sounds rather cavalier. |
14 |
|
15 |
Generally I don't think there should be a central catch-all variable for |
16 |
this, ebuilds should use their own unlikely variable as needed if using |
17 |
this route until a better solution. |
18 |
|
19 |
e.g. MARIADB_I_ALLOW_THE_DESTRUCTION_OF_MY_DATABASE=yes |
20 |
|
21 |
Could take it further and require that =yes be =${PV} so that it only |
22 |
works once if forgotten. |
23 |
|
24 |
Then users setting this in not-so-great ways are still unlikely to be |
25 |
bitten by it. |
26 |
-- |
27 |
ionen |