| 1 |
On 17.2.2010 16.33, Torsten Veller wrote: |
| 2 |
|
| 3 |
> |
| 4 |
>> --- eutils.eclass 15 Feb 2010 02:10:39 -0000 1.330 |
| 5 |
>> +++ eutils.eclass 17 Feb 2010 14:13:16 -0000 |
| 6 |
>> @@ -50,6 +50,15 @@ |
| 7 |
>> done |
| 8 |
>> fi |
| 9 |
>> } |
| 10 |
>> +else |
| 11 |
>> + ebeep() { |
| 12 |
>> + eqawarn "ebeep is not defined in EAPI=3, please file |
| 13 |
> |
| 14 |
> The problem here is that eqawarn isn't defined in EAPI 3. |
| 15 |
> |
| 16 |
|
| 17 |
Just shows that committing things to central eclasses without review is |
| 18 |
a bad thing. I improved the code so that it doesn't at least call |
| 19 |
eqawarn without first checking if it exists. Instead of code like this |
| 20 |
in the eclasses, I think this should be done by Portage grepping logs. I |
| 21 |
think it's already running searches over it for gcc things any way. |
| 22 |
|
| 23 |
Regards, |
| 24 |
Petteri |
Archives