| 1 |
> # @CODE |
| 2 |
> # Michał Górny <gentoo@××××××××××.pl> |
| 3 |
> # @CODE |
| 4 |
|
| 5 |
this is not what @code is designed for. punt it. |
| 6 |
|
| 7 |
> : ${SCONS_MIN_VERSION} |
| 8 |
|
| 9 |
useless statement. punt it. |
| 10 |
|
| 11 |
> : ${EXTRA_ESCONS:=} |
| 12 |
|
| 13 |
replace with @DEFAULT_UNSET |
| 14 |
|
| 15 |
> scons ${MAKEOPTS} ${EXTRA_ESCONS} "${@}" |
| 16 |
|
| 17 |
this should be echoed just like emake and econf and other things do now. |
| 18 |
set -- scons $(scons_makeopts) ${EXTRA_ESCONS} "$@" |
| 19 |
echo "$@" |
| 20 |
"$@" |
| 21 |
|
| 22 |
> scons_clean_makeopts |
| 23 |
|
| 24 |
better to do this on the fly and inline. otherwise you prevent the ebuild |
| 25 |
from being used in conjunction with standard make builds. |
| 26 |
|
| 27 |
i.e. have it parse ${MAKEOPTS} and echo the result, then change escons to call |
| 28 |
it all by itself. this isnt something ebuild maintainers should be bothered |
| 29 |
with. `escons` should be sufficient. |
| 30 |
|
| 31 |
> scons_use() |
| 32 |
|
| 33 |
keep the use_xxx style ... so rename it to "use_scons()" |
| 34 |
|
| 35 |
> local varname=${2:-${flag}} |
| 36 |
|
| 37 |
should be stripping possible leading ! so that people can do `use_scons !foo |
| 38 |
moo` just like they can today with `use_with $foo moo` |
| 39 |
-mike |
Archives