Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-dev
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-dev@g.o
From: Mike Frysinger <vapier@g.o>
Subject: Re: Re: New eclass: scons.eclass
Date: Sun, 22 Aug 2010 17:06:22 -0400
> # @CODE
> # Michał Górny <gentoo@...>
> # @CODE

this is not what @code is designed for.  punt it.

> : ${SCONS_MIN_VERSION}

useless statement.  punt it.

> : ${EXTRA_ESCONS:=}

replace with @DEFAULT_UNSET

> 	scons ${MAKEOPTS} ${EXTRA_ESCONS} "${@}"

this should be echoed just like emake and econf and other things do now.
	set -- scons $(scons_makeopts) ${EXTRA_ESCONS} "$@"
	echo "$@"
	"$@"

> scons_clean_makeopts

better to do this on the fly and inline.  otherwise you prevent the ebuild 
from being used in conjunction with standard make builds.

i.e. have it parse ${MAKEOPTS} and echo the result, then change escons to call 
it all by itself.  this isnt something ebuild maintainers should be bothered 
with.  `escons` should be sufficient.

> scons_use()

keep the use_xxx style ... so rename it to "use_scons()"

>	local varname=${2:-${flag}}

should be stripping possible leading ! so that people can do `use_scons !foo 
moo` just like they can today with `use_with $foo moo`
-mike
Attachment:
signature.asc (This is a digitally signed message part.)
References:
New eclass: scons.eclass
-- Michał Górny
Re: New eclass: scons.eclass
-- Michał Górny
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
Re: New eclass: scons.eclass
Next by thread:
Re: Re: New eclass: scons.eclass
Previous by date:
[RFC] GLes and OpenVG related management
Next by date:
Re: Re: New eclass: scons.eclass


Updated Jun 29, 2012

Summary: Archive of the gentoo-dev mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.