1 |
On 03/06/10 23:27, Mike Frysinger wrote: |
2 |
> On Wednesday 24 February 2010 15:27:21 ChIIph wrote: |
3 |
> |
4 |
>> Here are some minor changes I'd like to propose to flag-o-matic's |
5 |
>> _filter-var() to work properly with LDFLAGS. |
6 |
>> Without this, things like "-Wl,-O1,--as-needed" won't be affected by any |
7 |
>> kind of filter since there are no spaces to separate each flag. |
8 |
>> |
9 |
>> I don't know of any better way to do this, but here's a patch that works |
10 |
>> just fine. |
11 |
>> |
12 |
> the func is used by other code where you dont want to screw with commas. |
13 |
> |
14 |
The commas are only added when there's LDFLAGS being changed. |
15 |
> plus, there are a few other ways to trick the system. |
16 |
> |
17 |
> my opinion is still: |
18 |
> - bypassing the system is sometimes useful |
19 |
> - use separate -Wl flags and things just work |
20 |
> |
21 |
Ok, but in the default profiles LDFLAGS are separated with commas, so |
22 |
for that second opinion to be possible, I think that should be changed. |
23 |
|
24 |
On the other hand, a lot of us use comma separated flags, so for all of |
25 |
us filter-ldflags doesn't work, and what I've modify doesn't mess with |
26 |
any of all the other function (or at least I haven't found the case in |
27 |
which it does). |
28 |
> so thanks, but no thanks |
29 |
> -mike |
30 |
> |
31 |
Anyway, filter-ldflags doesn't work like it is right now, I'm not saying |
32 |
use _my_ code, but use whatever you think it's best to fix this. |
33 |
|
34 |
(Please, don't CC me, I'm already in gentoo-dev list) |
35 |
|
36 |
Cheers, |
37 |
Tomas |