Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-dev
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-dev@g.o
From: Mike Frysinger <vapier@g.o>
Subject: Re: [gentoo-commits] gentoo-x86 commit in sys-libs/glibc/files/eblits: pkg_preinst.eblit
Date: Wed, 13 Oct 2010 20:12:25 -0400
On Fri, Oct 8, 2010 at 11:33 AM, Diego Petteno (flameeyes)
<flameeyes@g.o> wrote:
> flameeyes    10/10/08 15:33:13
>
>  Modified:             pkg_preinst.eblit
>  Log:
>  QA: avoid using $D when testing the just-built loader, as it might cause trouble when it contains colon characters; the fix is trivial.

you'd think trivial fixes wouldnt contain bugs ...

> +               pushd "${D}"/$(get_libdir) 2>/dev/null
> +               ./ld-*.so --library-path . ${x} > /dev/null \
>                        || die "simple run test (${x}) failed"
> +               popd 2>/dev/null

yet another reason (strace also readily comes to mind) i keep asking
you to post fixes and/or notify maintainers (base-system/toolchain)
instead of just committing things.  pushd/popd do not write to stderr.
 so this change now echoes the dirs when people emerge it.  plus, this
really should be outside of the loop.
-mike


Replies:
Re: [gentoo-commits] gentoo-x86 commit in sys-libs/glibc/files/eblits: pkg_preinst.eblit
-- Diego Elio Pettenò
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
perl-5.12 news item
Next by thread:
Re: [gentoo-commits] gentoo-x86 commit in sys-libs/glibc/files/eblits: pkg_preinst.eblit
Previous by date:
Re: Re: [gentoo-commits] gentoo-x86 commit in net-misc/openvpn: ChangeLog openvpn-2.1.3.ebuild
Next by date:
Re: [gentoo-commits] gentoo-x86 commit in sys-libs/glibc/files/eblits: pkg_preinst.eblit


Updated Jun 29, 2012

Summary: Archive of the gentoo-dev mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.