Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-dev
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-dev@g.o
From: Michał Górny <mgorny@g.o>
Subject: Re: git-2: a bunch of patches to review
Date: Thu, 22 Sep 2011 13:27:47 +0200
On Thu, 22 Sep 2011 10:58:28 +0000
"Jorge Manuel B. S. Vicetto" <jmbsvicetto@g.o> wrote:

> On 22-09-2011 08:11, Michał Górny wrote:
> > On Thu, 22 Sep 2011 09:01:17 +0200 Ulrich Mueller <ulm@g.o>
> > wrote:
> > 
> >>> Attaching fixed version of the last two patches, and a
> >>> complete eclass for convenience.
> >> 
> >> Just a general comment: Is it really necessary to change all [[
> >> -n ${foo} ]] and [[ -z ${foo} ]] conditionals to the more
> >> obscure [[ ${foo} ]] and [[ ! ${foo} ]]?
> >> 
> >> The shortest possible form is not always the one that's best
> >> readable.
> > 
> > The style change was approved by Donnie already.
> 
> You mean that Donnie agreed with the style change. It's not up to any
> individual developer to "approve" such a change for the entire tree.

What kind of 'entire tree'? It is just a single eclass, and its
maintainer approves coding style change. Where do you see a problem
with that?

-- 
Best regards,
Michał Górny
Attachment:
signature.asc (PGP signature)
Replies:
Re: git-2: a bunch of patches to review
-- Andreas K. Huettel
References:
Re: git-2: a bunch of patches to review
-- Michał Górny
Re: git-2: a bunch of patches to review
-- Ulrich Mueller
Re: git-2: a bunch of patches to review
-- Michał Górny
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
Re: git-2: a bunch of patches to review
Next by thread:
Re: git-2: a bunch of patches to review
Previous by date:
Re: Packages up for grabs: virtual/{cron,dev-manager,inetd,libc,linux-sources,man,os-headers,package-manager,skkserv,ssh,w3m}
Next by date:
Re: git-2: a bunch of patches to review


Updated Jun 29, 2012

Summary: Archive of the gentoo-dev mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.