1 |
On Tue, Apr 29, 2003 at 07:44:41PM +0000, Mikael Andersson wrote: |
2 |
> Gentoo is moving to slow this is why this kind of ideas emerge. It might be |
3 |
> moving fast, but obviously still too slow for many. I've got a few ebuilds |
4 |
> done which i haven't even bothered to try to get in since i've seen the queue |
5 |
> in bugzillla and I'm sure several others are in the same situation. |
6 |
Seeing this. I have a specific request to make. Could you please ensure |
7 |
that your ebuilds are tagged with the 'EBUILD' keyword, to make them |
8 |
easier to find firstly. Secondly, just as an idea, a developer that has |
9 |
some time to go thru submitted ebuilds and review them for style and |
10 |
correctness (as I did for the ebuild mentioned above in this thread). |
11 |
|
12 |
> On Friday 25 April 2003 21.00, Robin H.Johnson wrote: |
13 |
> > On Fri, Apr 25, 2003 at 09:57:15PM +0200, kikov@××××××××××.com wrote: |
14 |
> > > Well... I'm a developer of a project. I have submitted via bugzilla |
15 |
> > > several bugs of one of the packages I need ( not from the project, just |
16 |
> > > a dependency ). Let see: http://bugs.gentoo.org/show_bug.cgi?id=2333 |
17 |
> > > ohh, yeah, 2002-05-02 07:28 EST... One year ago... |
18 |
> > > The bug is still opened. |
19 |
> > Go back and read my posting about why many ebuilds don't get into the |
20 |
> > tree. |
21 |
> I didn't see a lot of comments about the ebuild not being up to par in |
22 |
> bugzilla. Maybe if a developer seeing a build not beeing 'good-enough' could |
23 |
> add a small note about this so we - The Users(tm) - or in another word, the |
24 |
> user community [3] can fix whats wrong. We aim to please ... |
25 |
My comments were included below in my previous email. I have also |
26 |
attached them to the bug item now. |
27 |
|
28 |
> > If you fix those issues, and fix that ebuild. |
29 |
> > Things to fix: |
30 |
> > add SLOT, add KEYWORDS, add IUSE, 'use foo' statement style, use PATCHES |
31 |
> > instead of patch+src_unpack, local variable declarations, unnessicary |
32 |
> > statement block in src_install, broken homepage URI, ALL documentation |
33 |
> > with the package should be installed (manpages and even the guys pgp |
34 |
> > key) , einstall instead of 'make install' and most importantly EBUILD |
35 |
> > CHANGELOG!!!!! |
36 |
> No need to yell, instead add that information to [1]. In a way it's written in |
37 |
> [2] but as that is targeted for developers it's hard to know whether or not |
38 |
lintool/repoman do remind you that some of those are required, but for |
39 |
the most part they require a human to check. The original ebuild looked |
40 |
as if it was written using only the guide, and none of the existing |
41 |
ebuilds in portage, many of which server as excellent examples of ebuild |
42 |
style and how things are done. |
43 |
However you are partially correct that some of this should be added to |
44 |
[1]. |
45 |
most importantly, |
46 |
- say required items SLOT/KEYWORDS/IUSE/HOMEPAGE |
47 |
- say that all documentation should be installed |
48 |
- recommend econf/emake/einstall instead of normal variants |
49 |
- patch+src_unpack is not efficent and maybe incorrect, use PATCHES="..." |
50 |
|
51 |
|
52 |
Some of the things I mentioned are also partially my personal |
53 |
preferences to make life easier on myself. People's code says a lot |
54 |
about them generally, and if your submitted ebuilds look sloppy and |
55 |
that lessens the chance that developers will even go thru them and |
56 |
say what is wrong, let along clean them up. |
57 |
|
58 |
> I'm required to add that to my update, and if i should attach another file |
59 |
> with the entire changelog/changelog entry. |
60 |
Attaching a simple text file with just your changelog entry would be |
61 |
sufficent if you are updating an existing package, or including a new |
62 |
changelog from the skeleton file for a new ebuild. (This is a personal |
63 |
preference again). |
64 |
|
65 |
> And equally important, somebody with the proper knowledge should get |
66 |
> lintool online again. Apparently it's broken ( see warnings in [2] ) |
67 |
> and sure enough it reports errors for baselayout and other core |
68 |
> packages so it's probably at least somewhat broken. |
69 |
Repoman replaced lintool. I don't unfortunetly know of a tool that users |
70 |
can use to check ebuilds themselves, as repoman requires a CVS checkout. |
71 |
I have said previously that lintool needs to come back myself, and I |
72 |
have submitted some fixes for it to bugzilla myself. That document [2] |
73 |
does appear to contradict itself. |
74 |
|
75 |
> > Is libcap even actively maintained still? If not and it is not widely |
76 |
> > used, then it is not likely to get into the tree at all. |
77 |
> Maybe Larry the cow will stop using gentoo then ? After all he liked being in |
78 |
> control. If the users isn't in control gentoo will stop beeing bleeding edge |
79 |
> and maybe end up only bleeding. |
80 |
I personally try to avoid packages that do not fill at least one of the |
81 |
following requirements: |
82 |
1) is actively maintained |
83 |
2) is widely used |
84 |
3) not directly useful to myself |
85 |
|
86 |
the reasoning behind 1) is that unmaintained packages upstream of Gentoo |
87 |
do cause problems. media-plugins/avi-xmms is a recent example. It is |
88 |
presently masked in packages.mask while it dies down further, at which |
89 |
point if it is no maintained again, it will probably be trimmed from the |
90 |
tree. |
91 |
|
92 |
> What are the purpose of being a meta distribution if only widely used packages |
93 |
> get into the tree ? |
94 |
> > If you resolve all of the above issues, and the package is still widely |
95 |
> > used (I want some proof of this), then I'll take the ebuild and maintain |
96 |
> > it in portage myself. |
97 |
> Well, this is a problem since not all packages wanting to be in portage will |
98 |
> be widely used. But i have hopes that these kind of problems will be resolved |
99 |
> with the restructuring of ebuild submission and maintainance in progress. |
100 |
For 2) packages that aren't actively maintained, but are widely used |
101 |
usually have enough other support and people working with them that it |
102 |
is possible to support them ourselves. An active and responsive mailing |
103 |
list for a package fills this well, or if there are good pages written |
104 |
up about the package on the web. Several actively maintained packages that |
105 |
use the library as a requirement would also serve to show that it is |
106 |
still in general use. |
107 |
|
108 |
Item 3) is somewhat different than the other two. If there is a package |
109 |
that doesn't fit into the other two, and I have a personal everyday use |
110 |
for it, I'm willing to put some of my time to keeping it working. |
111 |
|
112 |
> [1] http://www.gentoo.org/doc/en/ebuild-submit.xml |
113 |
> [2] http://www.gentoo.org/doc/en/gentoo-howto.xml |
114 |
> [3] http://www.gentoo.org/main/en/about.xml |
115 |
|
116 |
-- |
117 |
Robin Hugh Johnson |
118 |
E-Mail : robbat2@××××××××××××××.net |
119 |
Home Page : http://www.orbis-terrarum.net/?l=people.robbat2 |
120 |
ICQ# : 30269588 or 41961639 |
121 |
GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85 |