Re: [gentoo-dev] New eclass for Python

[Krzysztof Pawlik]

On 29/02/12 04:21, Sergei Trofimovich wrote:
> On Tue, 28 Feb 2012 22:13:36 +0100
> Krzysztof Pawlik <nelchael@g.o> wrote:
>
>> I'm attaching the eclass itself and two ebuilds using it, code is also available
>> in my overlay at http://git.overlays.gentoo.org/gitweb/?p=dev/nelchael.git;a=summary
> Nice!
>
>> eclass/python-distutils-ng.eclass
>> 236                 # TODO: Pick default implementation
>> 237                 for impl in python{2_7,2_6,2_5,3_2,2_1} pypy{1_8,1_7} jython2_5; do
>
> Looks like 2_1 should be 3_1

Yes! Thank you.

> minor suggestion:
> s/_python-distutils-ng_run_for_all_impls/_python-distutils-ng_run_for_each_impl/g

LGTM, changed.

-- 
Krzysztof Pawlik  <nelchael at gentoo.org>  key id: 0xF6A80E46
desktop-misc, java, vim, kernel, python, apache...