Note: Due to technical difficulties, the Archives are currently not up to date.
GMANE provides an alternative service for most mailing lists. c.f. bug 424647
On Thu, 22 Sep 2011 09:01:17 +0200
Ulrich Mueller <ulm@g.o> wrote:
> > Attaching fixed version of the last two patches, and a complete
> > eclass for convenience.
>
> Just a general comment: Is it really necessary to change all
> [[ -n ${foo} ]] and [[ -z ${foo} ]] conditionals to the more obscure
> [[ ${foo} ]] and [[ ! ${foo} ]]?
>
> The shortest possible form is not always the one that's best readable.
The style change was approved by Donnie already.
Also, this one looks better when a particular var is used as a 'bash
boolean', e.g. EVCS_OFFLINE, bare, etc. Then [[ ${EVCS_OFFLINE} ]] is
more explanatory than [[ -n ${EVCS_OFFLINE} ]].
--
Best regards,
Michał Górny
|
| References: |
Re: git-2: a bunch of patches to review
-- Michał Górny
|
Re: git-2: a bunch of patches to review
-- Ulrich Mueller
|
| Navigation: |
|
Lists:
gentoo-dev:
< Prev
By Thread
Next >
< Prev
By Date
Next >
|
| Previous by thread: |
| Re: git-2: a bunch of patches to review |
| Next by thread: |
| Re: git-2: a bunch of patches to review |
| Previous by date: |
| Re: git-2: a bunch of patches to review |
| Next by date: |
| Packages up for grabs: virtual/{cron,dev-manager,inetd,libc,linux-sources,man,os-headers,package-manager,skkserv,ssh,w3m} |
|
