Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: williamh@g.o
Subject: Re: [gentoo-dev] Initial review for github-snapshot.eclass
Date: Tue, 31 May 2011 19:46:33
Message-Id: 20110531214553.37905efd@pomiocik.lan
In Reply to: Re: [gentoo-dev] Initial review for github-snapshot.eclass by William Hubbs
1 On Tue, 31 May 2011 14:28:00 -0500
2 William Hubbs <williamh@g.o> wrote:
3
4 > On Tue, May 31, 2011 at 04:24:23PM +0200, Michał Górny wrote:
5 > > EAPI=4
6 > >
7 > > inherit github-snapshot
8 > >
9 > > DESCRIPTION="Random github package"
10 > > HOMEPAGE="https://github.com/foo/bar"
11 >
12 > bar is actually ${PN}.
13
14 AFAIK it is a bad practice to use any variables in HOMEPAGE. Reason
15 unknown, vim highlights this in red.
16
17 > > SRC_URI="http://github.com/foo/${PN}/tarball/${P} -> ${P}.tar.gz"
18 >
19 > The first ${P} above isn't right, because that is where the tag of the
20 > snapshot goes.
21
22 This is a slightly modified copy-paste from an ebuild. In this
23 particular example, the tag was same as ${P}.
24
25 It is just an example. It's supposed to shortly show what needs to be
26 changed and what needs not. My main intent is not to suggest creating
27 additional variables like GITHUB_TAG and so on.
28
29 --
30 Best regards,
31 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature