Gentoo Archives: gentoo-dev

From: Maxim Koltsov <maksbotan@g.o>
To: "Michał Górny" <mgorny@g.o>, gentoo-dev@l.g.o, 0xd34df00d@×××××.com
Subject: Re: [gentoo-dev] Re: RFC: leechcraft.eclass
Date: Thu, 18 Aug 2011 18:33:56
Message-Id: CAB_Kkxz7Kr=fPPUk8C_jdoJ825yEVsqm2uET+koPfsT6mdR68Q@mail.gmail.com
In Reply to: Re: [gentoo-dev] Re: RFC: leechcraft.eclass by "Michał Górny"
1 2011/8/18 Michał Górny <mgorny@g.o>:
2 > On Thu, 18 Aug 2011 19:30:29 +0400
3 > Maxim Koltsov <maksbotan@g.o> wrote:
4 >
5 >> if [ "${LEECHCRAFT_PACKAGE_CATEGORY+x}" != "x" ]; then
6 >>       CMAKE_USE_DIR="${S}/src/plugins/${LEECHCRAFT_PACKAGE_CATEGORY}/${PN#leechcraft-}"
7 >> elif [ ${PN} != "leechcraft-core" ]; then
8 >>               CMAKE_USE_DIR="${S}/src/plugins/${PN#leechcraft-}"
9 >
10 > [[ ]] is better here because it's a bash builtin. And you don't need
11 > quotes there.
12 >
13 > What should happen if LEECHCRAFT_PACKAGE_CATEGORY is set to ''?
14
15 Fixed, i think. In this version empty variable will be handled correctly.
16
17 --
18 Regards, Maxim.

Attachments

File name MIME type
leechcraft.eclass application/octet-stream

Replies

Subject Author
Re: [gentoo-dev] Re: RFC: leechcraft.eclass "Michał Górny" <mgorny@g.o>