Note: Due to technical difficulties, the Archives are currently not up to date.
GMANE provides an alternative service for most mailing lists. c.f. bug 424647
On Wednesday 18 January 2012 16:17:50 Michał Górny wrote:
> On Wed, 18 Jan 2012 15:39:24 -0500 Mike Frysinger wrote:
> > yes. this func is the primer so it starts at 1, and after this,
> >
> > people call cdrom_load_next_cd which then prints out:
> > einfo "Found CD #2 root at ..."
> > einfo "Found CD #3 root at ..."
> > einfo "Found CD #4 root at ..."
> >
> > since they have the same `einfo` message structure
> >
> > i could replace the variable in the first einfo with a "1", but it
> > gains nothing, and imo kills the "these messages are clearly in sync
> > between these two funcs".
>
> Then please clearly use the ${!...} magic to get CD_ROOT_1 rather than
> mixing hardcoded '1' and $CDROM_CURRENT_ID.
pretty sure that's independent of the `einfo` output
i'm probably not going to bother looking for feedback on the code style until
it gets rewritten in arrays
-mike
|
| Attachment: |
|
signature.asc (This is a digitally signed message part.)
|
|
