Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-dev
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-dev@g.o
From: Michael Orlitzky <michael@...>
Subject: Re: [PATCH] prune_libtool_files(): go into .a removal only when .a exists.
Date: Fri, 15 Jun 2012 11:11:44 -0400
On 06/15/12 09:32, Michał Górny wrote:
> It is a little confusing when the function reports .a removal when no
> such file exists. Also, explain why the file is removed.

Why keep the "-f"?


> ---
>  eclass/eutils.eclass |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/eclass/eutils.eclass b/eclass/eutils.eclass
> index 116f7bc..931d97d 100644
> --- a/eclass/eutils.eclass
> +++ b/eclass/eutils.eclass
> @@ -1438,8 +1438,10 @@ prune_libtool_files() {
>  
>  		# Remove static libs we're not supposed to link against.
>  		if grep -q '^shouldnotlink=yes$' "${f}"; then
> -			einfo "Removing unnecessary ${archivefile#${D%/}}"
> -			rm -f "${archivefile}"
> +			if [[ -f ${archivefile} ]]; then
> +				einfo "Removing unnecessary ${archivefile#${D%/}} (static plugin)"
> +				rm -f "${archivefile}"
> +			fi
>  
>  			# The .la file may be used by a module loader, so avoid removing it
>  			# unless explicitly requested.



Replies:
Re: [PATCH] prune_libtool_files(): go into .a removal only when .a exists.
-- Michał Górny
References:
[PATCH] prune_libtool_files(): go into .a removal only when .a exists.
-- Michał Górny
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
[PATCH] prune_libtool_files(): go into .a removal only when .a exists.
Next by thread:
Re: [PATCH] prune_libtool_files(): go into .a removal only when .a exists.
Previous by date:
Re: ebuild laziness and binpkg overhead
Next by date:
Re: [PATCH] prune_libtool_files(): go into .a removal only when .a exists.


Updated Jun 29, 2012

Summary: Archive of the gentoo-dev mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.