| 1 |
On Thu, 20 Mar 2008 18:02:31 -0600 |
| 2 |
Ryan Hill <dirtyepic@g.o> wrote: |
| 3 |
> > How about just checking EUID == 0 in src_test and skip the tests |
| 4 |
> > (with a ewarn message) if it doesn't match your needs? |
| 5 |
> |
| 6 |
> I thought I remembered someone raising a stink about checking |
| 7 |
> permissions being a race condition because the condition can change |
| 8 |
> between the checking and performing the action. Maybe that was only |
| 9 |
> about write permissions... |
| 10 |
|
| 11 |
That's in cases like if [[ -w foo ]] ; then blah foo ; fi . Checking a |
| 12 |
variable that's constant for the phase is not racy. |
| 13 |
|
| 14 |
> If checking EUID is an acceptable method, |
| 15 |
> it should be relatively simple to write an eclass to handle the |
| 16 |
> common cases and have ebuilds use that instead of checking $FEATURES |
| 17 |
> (which i do think is a bug). |
| 18 |
|
| 19 |
Does it really need an eclass for something so simple? |
| 20 |
|
| 21 |
-- |
| 22 |
Ciaran McCreesh |
Archives