Re: [gentoo-dev] libgphoto2-2.4.10 news item

[Gilles Dartiguelongue]

Le lundi 14 février 2011 à 11:42 +0100, Pacho Ramos a écrit :
> El lun, 14-02-2011 a las 11:40 +0100, Pacho Ramos escribió:
> > El lun, 14-02-2011 a las 11:37 +0100, Gilles Dartiguelongue escribió:
> > > Le lundi 14 février 2011 à 11:34 +0100, Pacho Ramos a écrit :
> > > > El lun, 14-02-2011 a las 11:24 +0100, Gilles Dartiguelongue escribió:
> > > > > Le lundi 14 février 2011 à 11:15 +0100, Pacho Ramos a écrit :
> > > > > > El dom, 13-02-2011 a las 18:03 +0100, Pacho Ramos escribió:
> > > > > > > Hello
> > > > > > >
> > > > > > > Please see attached news item for reviewing as part of the fix for
> > > > > > > http://bugs.gentoo.org/show_bug.cgi?id=346491
> > > > > > >
> > > > > > > Thanks
> > > > > > >
> > > > > >
> > > > > > This is an updated news item for trying to cover Ciaran and Matthew
> > > > > > suggestions:
> > > > > > 1. It doesn't ask people to use USE="*"
> > > > > > 2. Before sending this, I would add all cameras to base/make.defaults as
> > > > > > already done for similar cases (like alsa, lcd devices and others)
> > > > > >
> > > > > > Do you agree with this?
> > > > > >
> > > > > > Thanks :-)
> > > > >
> > > > > no, adding all cameras is most likely a waste of time for maintainers,
> > > > > it is prone to errors when cameras get added/removed which is already
> > > > > complicated enough to maintain.
> > > > >
> > > >
> > > > What kind of errors will people see? As I have just tested, if I run:
> > > >  CAMERAS="bbhsgdd" emerge -pv media-libs/libgphoto2
> > > >
> > > > I get no error (that would be equivalent to a camera that got removed on
> > > > a bump).
> > >
> > > I was talking about human error while adding stuff to appropriate files.
> > > It happens already often enough with just the IUSE_EXPAND feature.
> > >
> >
> > Then, as ebuild uses EAPI2, why don't enable all of them in ebuild
> > itself by default?
> >  for camera in ${IUSE_CAMERAS}; do
> > -	IUSE="${IUSE} cameras_${camera}"
> > +	IUSE="${IUSE} +cameras_${camera}"
> >  done
> >
> > Looks to work as expected here and wouldn't be prone to human errors
>
> Bleh, forget it, it is a headache to disable cameras then :-S

and it didn't work when I tried it as I said in the bug report, I guess
it depends on the version of portage and I haven't checked other PMs.

-- 
Gilles Dartiguelongue <eva@g.o>
Gentoo