| 1 |
On 2/21/10 5:08 AM, Ryan Hill wrote: |
| 2 |
> I have one simple request. When you make a non-trivial change to an ebuild - |
| 3 |
> a patch, a version bump, anything that can effect the behaviour of the |
| 4 |
> package - please run the test suite. |
| 5 |
|
| 6 |
Yeah, on my dev box I just run with FEATURES="test" all the time. Then |
| 7 |
it's impossible to forget it. And I also catch failures in other packages. |
| 8 |
|
| 9 |
Maybe it should get more exposure in the developer docs? |
| 10 |
|
| 11 |
> If it fails, fix it. Or restrict it. Or even make it non-fatal if there's |
| 12 |
> no other choice. |
| 13 |
|
| 14 |
It's really frustrating when there is a bug reported about package |
| 15 |
failing tests and everybody can reproduce it, yet the maintainer doesn't |
| 16 |
at least put RESTRICT="test" in the ebuild. |
| 17 |
|
| 18 |
Is it acceptable for another dev to jump in and add RESTRICT="test" to |
| 19 |
an ebuild if the maintainer does not respond to a bug report in a timely |
| 20 |
manner? |
| 21 |
|
| 22 |
The concern here may be that it's papering over the real problem, but |
| 23 |
the good side is that it'd make running with FEATURES=test much easier. |
| 24 |
|
| 25 |
By the way, for packages that fail the test suite and refuse to disable |
| 26 |
it, I change the env locally so that FEATURES=-test (via /etc/portage/env). |
| 27 |
|
| 28 |
Paweł Hajdan jr |
Archives