| 1 |
"Robin H. Johnson" <robbat2@g.o> posted |
| 2 |
20080822030358.GK24123@××××××××××××××××××××××××.net, excerpted below, on |
| 3 |
Thu, 21 Aug 2008 20:03:58 -0700: |
| 4 |
|
| 5 |
> On Wed, Aug 20, 2008 at 02:57:03AM +0000, Mike Frysinger (vapier) wrote: |
| 6 |
>> 1.1 |
| 7 |
>> sys-kernel/linux-headers/linux-headers-2.6.26.ebuild |
| 8 |
> ... |
| 9 |
>> src_install() { |
| 10 |
>> kernel-2_src_install |
| 11 |
>> cd "${D}" |
| 12 |
>> egrep -r \ |
| 13 |
>> -e '[[:space:]](asm|volatile|inline)[[:space:](]' \ -e |
| 14 |
>> '\<([us](8|16|32|64))\>' \ |
| 15 |
>> . |
| 16 |
>> headers___fix $(find -type f) |
| 17 |
>> } |
| 18 |
> ... |
| 19 |
> |
| 20 |
> Are you missing a pipe after the egrep statement? What's the point of |
| 21 |
> just spitting to stdout? |
| 22 |
|
| 23 |
FWIW that bit's not new code; it's there in at least 2.6.25-r4 (all I |
| 24 |
checked) as well. |
| 25 |
|
| 26 |
This could probably do with a comment/echo/einfo saying such, but it |
| 27 |
appears to me that the egrep is simply informational/debugging, as the |
| 28 |
fix__headers call (function inherited from kernel-2.eclass) appears to |
| 29 |
ultimately deal with the same list, after a bit of additional filtering |
| 30 |
of the list of regular files fed into it from find. |
| 31 |
|
| 32 |
(I investigated since I had the package in my updates today and after |
| 33 |
seeing the comment here, wanted to ensure it wasn't potentially |
| 34 |
destabilizing typo.) |
| 35 |
|
| 36 |
-- |
| 37 |
Duncan - List replies preferred. No HTML msgs. |
| 38 |
"Every nonfree program has a lord, a master -- |
| 39 |
and if you use the program, he is your master." Richard Stallman |
Archives