[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-text/ghostscript-gpl: metadata.xml ChangeLog ghostscript-gpl-9.04-r4.ebuild

[justin]

On 11/12/11 11:25 AM, Samuli Suominen wrote:
> On 11/12/2011 12:21 PM, Justin Lecher (jlec) wrote:
>> jlec        11/11/12 10:21:37
>>
>>   Modified:             metadata.xml ChangeLog
>>                         ghostscript-gpl-9.04-r4.ebuild
>>   Log:
>>   Fixed slotting for media-libs/tiff
>>
>>   (Portage version: 2.2.0_alpha73/cvs/Linux x86_64)
>>
>> Revision  Changes    Path
>> 1.3                  app-text/ghostscript-gpl/metadata.xml
>>
>> file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-text/ghostscript-gpl/metadata.xml?rev=1.3&view=markup
>> plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-text/ghostscript-gpl/metadata.xml?rev=1.3&content-type=text/plain
>> diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-text/ghostscript-gpl/metadata.xml?r1=1.2&r2=1.3
>>
>> Index: metadata.xml
>> ===================================================================
>> RCS file: /var/cvsroot/gentoo-x86/app-text/ghostscript-gpl/metadata.xml,v
>> retrieving revision 1.2
>> retrieving revision 1.3
>> diff -u -r1.2 -r1.3
>> --- metadata.xml	2 Jun 2011 09:59:25 -0000	1.2
>> +++ metadata.xml	12 Nov 2011 10:21:37 -0000	1.3
>> @@ -1,8 +1,8 @@
>>  <?xml version="1.0" encoding="UTF-8"?>
>>  <!DOCTYPE pkgmetadata SYSTEM "http://www.gentoo.org/dtd/metadata.dtd">
>>  <pkgmetadata>
>> -<herd>printing</herd>
>> -  <use>
>> -    <flag name="bindist">Disable dejavu support for binary distribution because of licensing issue</flag>
>> -  </use>
>> +	<herd>printing</herd>
>> +	<use>
>> +		<flag name="bindist">Disable dejavu support for binary distribution because of licensing issue</flag>
>> +	</use>
>>  </pkgmetadata>
>
> I wonder what that has to do with "Fixed slotting for media-libs/tiff"?
>

This means, we better should use media-libs/tiff:0 to avoid problem if
tkimg is installed. I added :0 to the tiff dep.

> Do we have a guideline or policy on using 2 spaces vs. tabs in .xml
> files and gentoo-x86? Just asking because I prefer 2 spaces over tabs.

I asked and as far as I can remember, there was a "do what you like"
answer. Especially older devs didn't like to be forced to anything here.
Why I changed it? Not directly by purpose. I am trying to fix formating
using xmlstartlet prior to commit, as I found that many metadata.xml do
not follow a clear rule. And xml formatting is a quite straight thing,
so I didn't thought people don't like it.

justin