Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-dev
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-dev@g.o
From: Jeroen Roovers <jer@g.o>
Subject: Re: Minor changes in python.eclass and distutils.eclass
Date: Tue, 6 Jul 2010 01:18:27 +0200
On Mon, 05 Jul 2010 22:50:56 +0000
"Jorge Manuel B. S. Vicetto" <jmbsvicetto@g.o> wrote:

> I'm not going to delve into the details that have been addressed all
> other this thread. Instead I'll just address one small issue.
> The use of *minor* in the title of this thread and the sheer size of
> the patch attached are not compatible. Please don't label changes
> such as these as *minor* in future instances.

Another major flaw on its own is the sheer size of the patch (it hadn't
been explicitly mentioned to my knowledge). Aren't we supposed to
commit early and often in open source projects instead of dumping all
your changes on reviewers at once (first fork and later merge)? And if
you're still going to do it, a the huge patch should only be necessary
to establish a single sweeping change, not many small changes.


     jer


Replies:
Re: Minor changes in python.eclass and distutils.eclass
-- Petteri R├Ąty
References:
Minor changes in python.eclass and distutils.eclass
-- Arfrever Frehtes Taifersar Arahesis
Re: Minor changes in python.eclass and distutils.eclass
-- Jorge Manuel B. S. Vicetto
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
Re: Minor changes in python.eclass and distutils.eclass
Next by thread:
Re: Minor changes in python.eclass and distutils.eclass
Previous by date:
Re: Minor changes in python.eclass and distutils.eclass
Next by date:
Re: Minor changes in python.eclass and distutils.eclass


Updated Jun 29, 2012

Summary: Archive of the gentoo-dev mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.