1 |
> # Copyright 1999-2004 Gentoo Foundation |
2 |
|
3 |
s/2004/2011/ |
4 |
|
5 |
have you looked at the man page output for this to make sure the white spacing |
6 |
you're putting into the comments properly carries over ? |
7 |
|
8 |
> # @ECLASS-VARIABLE: EBO_DESCRIPTION |
9 |
> # @DESCRIPTION: |
10 |
> # Should be set. Completes the describtion of the embassy module as follows: |
11 |
|
12 |
i dont understand what this is trying to say (ignoring the spelling mistake in |
13 |
description) |
14 |
|
15 |
> # EMBOSS integrated version of EBO_DESCRIPTION" |
16 |
|
17 |
i see just one quote. it needs a friend. |
18 |
|
19 |
> # @ECLASS-VARIABLE: EBO_PATCH |
20 |
> # @DEFAULT_UNSET |
21 |
> # @DESCRIPTION: Specify the patch level of EMBOSS. Only available for the |
22 |
emboss ebuild. |
23 |
> # The patch wil be fetch from: |
24 |
|
25 |
wil -> will |
26 |
|
27 |
> # @ECLASS-VARIABLE: NO_RECONF |
28 |
> # @DEFAULT_UNSET |
29 |
> # @DESCRIPTION: |
30 |
> # Set this, if you do not want to have eautoreconf be run after patching. |
31 |
|
32 |
please namespace all variables consistently |
33 |
|
34 |
> # @ECLASS-VARIABLE: EBO_ECONF |
35 |
|
36 |
EBO_EXTRA_ECONF is better for consistency sake too |
37 |
|
38 |
> EAPI="4" |
39 |
|
40 |
erp! |
41 |
|
42 |
> HOMEPAGE="http://emboss.sourceforge.net" |
43 |
|
44 |
could do with a trailing "/" |
45 |
|
46 |
> IUSE="mysql pdf png postgres static-libs X " |
47 |
|
48 |
no trailing space. let the person appending the variable add the space: |
49 |
IUSE+=" moo" |
50 |
|
51 |
> DOCS="AUTHORS ChangeLog NEWS README " |
52 |
|
53 |
no need for that trailing space, and usually DOCS is left for end ebuilds isnt |
54 |
it ? eclasses should append it. |
55 |
|
56 |
> |
57 |
> if [[ ${PN} == "emboss" ]] ; then |
58 |
> EBOV=${PV/_p*} |
59 |
> DESCRIPTION="The European Molecular Biology Open Software Suite - A |
60 |
sequence analysis package" |
61 |
> SRC_URI="ftp://emboss.open-bio.org/pub/EMBOSS/EMBOSS-${EBOV}.tar.gz" |
62 |
> [[ -n ${EBO_PATCH} ]] && SRC_URI+=" ftp://${PN}.open- |
63 |
bio.org/pub/EMBOSS/fixes/patches/patch-1-${EBO_PATCH}.gz -> ${P}.patch.gz" |
64 |
> IUSE+="minimal " |
65 |
> RDEPEND+=" |
66 |
> !sys-devel/cons |
67 |
> " |
68 |
> PDEPEND+=" |
69 |
> !minimal? ( |
70 |
> sci-biology/aaindex |
71 |
> sci-biology/cutg |
72 |
> sci-biology/prints |
73 |
> sci-biology/prosite |
74 |
> sci-biology/rebase |
75 |
> sci-biology/transfac |
76 |
> ) |
77 |
> " |
78 |
> S=${WORKDIR}/EMBOSS-${EBOV} |
79 |
> DOCS+="FAQ THANKS " |
80 |
|
81 |
this doesnt make much sense to me. shouldnt this all be in the emboss ebuild |
82 |
instead of the eclass ? |
83 |
|
84 |
> # The EMBASSY package name, retrieved from the inheriting ebuild's name |
85 |
> EN=${PN:8} |
86 |
|
87 |
should there be some checking here to make sure it starts with "embassy-" or |
88 |
whatever you're expecting ? |
89 |
|
90 |
> # The full name and version of the EMBASSY package (excluding the Gentoo |
91 |
> # revision number) |
92 |
> EF=$(echo ${EN} | tr "[:lower:]" "[:upper:]")-${PV} |
93 |
|
94 |
ugh, but i guess we cant do much until we have newer bash |
95 |
|
96 |
> EBO_DESCRIPTION=${EBO_DESCRIPTION:=${EN}} |
97 |
|
98 |
tricky, but wrong. i guess you actually want: |
99 |
: ${EBO_DESCRIPTION:=${EN}} |
100 |
|
101 |
> DEPEND+=">=sci-biology/emboss-6.3.1_p4[mysql=,pdf=,png=,postgres=,static- |
102 |
libs=,X=] " |
103 |
|
104 |
space should be at the start of the string, not the end |
105 |
|
106 |
> # @FUNCTION: emboss_src_prepare |
107 |
> # @USAGE: |
108 |
> # @RETURN: |
109 |
> # @MAINTAINER: |
110 |
|
111 |
i dont think these three tags make sense. not even sure if this last one is |
112 |
even allowed. best to just punt. |
113 |
|
114 |
same goes for all the other funcs below. |
115 |
|
116 |
> emboss_src_prepare() { |
117 |
> [[ ${PN} == emboss ]] && [[ -n ${EBO_PATCH} ]] && epatch |
118 |
"${WORKDIR}"/${P}.patch |
119 |
|
120 |
guess that would be moved to the emboss ebuild |
121 |
|
122 |
> [[ -f "${FILESDIR}"/${PF}.patch ]] && epatch "${FILESDIR}"/${PF}.patch |
123 |
|
124 |
technically, no need to quote FILESDIR here as the [[...]] takes care of it |
125 |
|
126 |
> # $(use_with png pngdriver "${EPREFIX}/usr") |
127 |
> # $(use_with pdf hpdf "${EPREFIX}/usr") |
128 |
> # $(use_with mysql mysql "${EPREFIX}/usr/bin/mysql_config") |
129 |
> # $(use_with postgres postgresql "${EPREFIX}/usr/bin/pg_config") |
130 |
|
131 |
do you really need full paths here ? are the configure scripts that screwed |
132 |
up ? ideally libs would be found via .pc files. |
133 |
|
134 |
> # $(use_enable amd64 64) |
135 |
|
136 |
oh god it burns so bad when i poo |
137 |
|
138 |
> emboss_src_install() { |
139 |
> default |
140 |
> mv "${ED}"/usr/share/EMBOSS/doc/* "${ED}"/usr/share/doc/${PF}/ |
141 |
> rm -rf "${ED}"/usr/share/EMBOSS/doc |
142 |
|
143 |
does the configure script respect --docdir= ? then you wouldnt need this |
144 |
clean up logic ... |
145 |
|
146 |
> [[ ${PN} == embassy ]] || EXPORT_FUNCTIONS src_prepare src_configure |
147 |
src_install |
148 |
|
149 |
this $PN logic should get punted |
150 |
-mike |