2010-07-05 20:00:11 Mark Loeser napisał(a):
> Arfrever Frehtes Taifersar Arahesis <Arfrever@g.o> said:
> > 2010-07-05 18:26:40 Samuli Suominen napisał(a):
> > > On 07/05/2010 07:17 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> > > > 2010-07-05 18:13:26 Samuli Suominen napisał(a):
> > > >> On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> > > >>> These minor changes in python.eclass and distutils.eclass have been already
> > > >>> reviewed on alias of Gentoo Python Project. It's recommended to be familiar
> > > >>> with internals of current code before trying to understand these minor changes.
> > > >>> Suggestions about indentation and quoting will be rejected.
> > > >>>
> > > >>
> > > >> You have been already told to get rid of all the color customizations in
> > > >> the python eclasses here:
> > > >>
> > > >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c2
> > > >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c3
> > > >>
> > > >> [ .. ]
> > > >>
> > > >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5
> > > >>
> > > >> The bug was wrongly closed as fixed, as it's not really fixed before
> > > >> it's all punted
> > > > 
> > > > Colors can be used with echo.
> > > > 
> > > 
> > > Stop using echo for output and switch to standard output functions, like
> > > einfo/eerror/elog/... like told in
> > > http://bugs.gentoo.org/show_bug.cgi?id=309057#c5
> > 
> > You should read relevant part of comment #7:
> > "The colors can of course be continued to be used in outputs that are purely build
> > time outputting and not for communicating things for users like what cmake builds do."
> > 
> > python.eclass uses colors for build time outputting, which doesn't communicate anything for users.
> 
> Everyone else has already made valid points.  I'm just picking this one
> to reply to now.  Please remove the colors you have added.  If you need
> a new function, say "eqawarn", we should have that added in the next
> EAPI with a description of when and where to use it.

In case of the colored message added in this patch, if einfo/elog/ewarn/eqawarn/eerror was used,
then its output wouldn't be logged by Portage.

-- 
Arfrever Frehtes Taifersar Arahesis